From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbcKHNhd (ORCPT ); Tue, 8 Nov 2016 08:37:33 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:62610 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbcKHNhb (ORCPT ); Tue, 8 Nov 2016 08:37:31 -0500 From: Arnd Bergmann To: "David S. Miller" Cc: Philippe Reynes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mii: report 0 for unknown lp_advertising Date: Tue, 08 Nov 2016 14:37:09 +0100 Message-ID: <2691679.uD93atpuSb@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161108133232.1571441-1-arnd@arndb.de> References: <20161108133232.1571441-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:O34gDFy9zP/ZHxEj2On1+sm68+6xUQYATvVc1mLC9/Z8512yZR1 qKPqUQMm1dsNjPif73J7MJhr0R/ce8ZARnY3gtnGS1NGRWSxes/ERPM77+Zs7Lxzs2fEI/o zn7EZOCd1pFl04aSWYhgcCppO1p869GUXFDQ3TECsW5rLslu4DuJ9yjSgqRR79cICL0GG2C p6V1qU+Ka4e169vehuOmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:nKCLc/SLjJY=:AwPhZWqzWzhI7Rp2JZcQxM mNq6kcXMonnzShdbyFRGoQficli+C5N5rk+Kr1Kqmie4GXkPdQ15knULKMNWKumcLqCLYM43T Qw4QEn0USNvpIRednG90pqLjipbKOi1WaalSprmwjdjYJjCaS9GFUkCQDQap1i6DM76L4nPen YxsUqYF1AU4pAHyjX40KjunE8tGiHjsdraJNAfAFhGnj/1iInk05CbULmFldUfobL9+1yXJ3z AesrecMAkUsjpsc94BQOyp7p2yumPPh3ZtYv9/zrm2uAsKDj1Vrw5vhPY6WIq99Zm6jvlNCZL VowXvBRaVmIfdd45chJTqfHHSvJLvf/5TVYTc+lfUuZS9KfhETm2isae0fqwq+j2kcWtFGr+X Z7XtyK4eK3DkYO2obc+AizaFbBzZiS53ds6DrxuWFNRK7Ai1RnFvhlUi3XiDXpr4CXZ25mMLg Xe6gqXSPSBXrUJyxAbkB1Y/2v+SxJJjM0Cpok3sDSJgjhCZsdZat8a10fiPqgirhSh7kEM5ZI KTpJAEdMZfd+UhzGi1DRgteES3fZVBrrh2RRrZ+woqZXPeujY9wFgv+0NBANk/HrGuRSVr1JD uwogtHji7ylezimFHTRLx4Ph/tbm1p9ZE2pV23gkLlxIHgzglgksmObBgP5rNuPAESUT1Pn0q qdyPe2rH4CjdYC4jE8kJwtJHX6PAoHs9rg7y5LGUMl9BElgojcqAUWiCh25s2p648djx0gW2R vCwJ2OAzh4YPJ9gx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 8, 2016 2:31:38 PM CET Arnd Bergmann wrote: > The newly introduced mii_ethtool_get_link_ksettings function sets > lp_advertising to an uninitialized value when BMCR_ANENABLE is not > set: > > drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings': > drivers/net/mii.c:224:2: error: 'lp_advertising' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > As documented in include/uapi/linux/ethtool.h, the value is > expected to be zero when we don't know it, so let's initialize > it to that. > > Fixes: bc8ee596afe8 ("net: mii: add generic function to support ksetting support") > Signed-off-by: Arnd Bergmann In case there was any doubt: the patch causing this is currently in net-next and has just shown up in linux-next. Arnd