From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbdHQPqr (ORCPT ); Thu, 17 Aug 2017 11:46:47 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:64737 "EHLO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbdHQPqp (ORCPT ); Thu, 17 Aug 2017 11:46:45 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Srinivas Pandruvada , Len Brown , Ingo Molnar , Peter Zijlstra , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook() Date: Thu, 17 Aug 2017 17:31:38 +0200 Message-ID: <2692371.TLU4a4PDeX@aspire.rjw.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > The callers already have the structure (struct update_util_data) where > the function pointer is saved by cpufreq_add_update_util_hook(). And its > better if the callers fill it themselves, as they can do it from the > governor->init() callback then, which is called only once per policy > lifetime rather than doing it from governor->start which can get called > multiple times. So what problem exactly is this addressing? Thanks, Rafael