From: "David Wang" <00107082@163.com>
To: "Florian Westphal" <fw@strlen.de>
Cc: "Daniel Xu" <dxu@dxuuu.xyz>,
"Pablo Neira Ayuso" <pablo@netfilter.org>,
"Jozsef Kadlecsik" <kadlec@netfilter.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re:Re: [PATCH] uapi/netfilter: Change netfilter hook verdict code definition from macro to enum
Date: Mon, 16 Oct 2023 17:22:36 +0800 (CST) [thread overview]
Message-ID: <269646ef.6122.18b37cb5c27.Coremail.00107082@163.com> (raw)
In-Reply-To: <20230928115359.GB27208@breakpoint.cc>
At 2023-09-28 19:53:59, "Florian Westphal" <fw@strlen.de> wrote:
>
>I was about to apply this as-is, but Pablo Neira would prefer to
>keep the defines as well.
>
>So, as a compromise, I would suggest to just *add*
>
>/* verdicts available to BPF are exported via vmlinux.h */
>enum {
> NF_DROP = 0,
> NF_ACCEPT = 1,
>};
>
>#define NF_DROP 0
>...
>
>This way BTF won't have the other verdicts, but ATM those
>cannot be used in BPF programs anyway.
>
>Would you mind making a new version of the patch?
>Otherwise I can mangle it locally here as needed.
Sorry for this late response, I got caught up by an unexpected personal "crisis" for quite a long while..
Hope you have already made the change, and it is OK.
David
prev parent reply other threads:[~2023-10-16 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 13:02 David Wang
2023-09-05 16:38 ` Daniel Xu
2023-09-05 16:57 ` David Wang
2023-09-07 2:21 ` Duncan Roe
2023-09-07 18:44 ` Florian Westphal
2023-09-28 11:53 ` Florian Westphal
2023-10-16 9:22 ` David Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=269646ef.6122.18b37cb5c27.Coremail.00107082@163.com \
--to=00107082@163.com \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=dxu@dxuuu.xyz \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®