From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D508C36E475 for ; Fri, 30 Jan 2026 11:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769774161; cv=none; b=Eo+cSHbvbZhQ+oz3dj0YN/zRhFxUOtYaYOIYL8oM/IsjR7RRlMEnVEkif7v/tgTz/LJRP1i5Myku/TA8hzUxvwmC7i5HhgszXoRvZTjjNJwlf6Fa6JwK4g1okbcUU7IfDW8tm3Lh8AelMx5Lhhz76iwIL4/l20bNVw4YIMH2tro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769774161; c=relaxed/simple; bh=OJwPTZRTEklOZhpT7S5bhlvgzfcai6Sxyl1nAIPFzMs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lDUFwel6z6Ez/0hWahham3zPKhJaVP3CTFZ3mFXmrO//Ro2/Ll/7PiYge61UnDH5TQ/OpmrK5HedDWWFrfSFBjp5KW/ZMzqs9egDGQK5g2tVAThkgVrCl2ecEZHPyRPl0uIB06Qt9o50chiP6H/BGIxfIS4iXmpvNJKUuj+DAeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZNJzxztk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KtC5OfJt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZNJzxztk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KtC5OfJt" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UAa2I31488285 for ; Fri, 30 Jan 2026 11:55:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +WZkU1lyCaEeWQ3hXRLyOfKOv0thvYXR823k7SIXJtQ=; b=ZNJzxztkk5D/w1Cm aryldQv/FAo2EFC0eh1VODa1GlDzBQdJcw5aaClXocDivbYCI50b08jRRlrRYP7k Y2em1NQiWVot9qt/gGf3qjJtDtYLG8s0WAdfF9H85yLAKy5tNdaFyS0c6LAXszzx ch6QcNlUAAdYxyZgOnipcIsN36ccsS1KeUDhJ/NYEYGdLoAo464N17czcmJQfW6k tdaheVv4gNJuulQXw+pDdthTd7+WqUoB2BUPk3t+eEP/2gN8reGp3/612/W9vgrv Tm/KPL4qhoNHfiIDU3cFwVu1VSyffmQ3KdcFnfr3T+X4L/Xui3apFwGeRkDml0hb PYOh6Q== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0bp3u2pu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 11:55:58 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88882c9b4d0so1539746d6.0 for ; Fri, 30 Jan 2026 03:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769774158; x=1770378958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+WZkU1lyCaEeWQ3hXRLyOfKOv0thvYXR823k7SIXJtQ=; b=KtC5OfJt/asQZgpzm6o/ZA3UyeQbaOEmXw4o1dAbg02jljyoDsgNFdcHLLd+e4QenE XmcXmCNyNurAq0X4Is57BKTXUmhv/7bRqI9y7s81Ps7yzpbzagYHiiP5/SFwvbaKLRFL yIQNJ1EZXBR+rHDcBM/5Gp1ykTlqV/XGEVIGpiWi+FdCbO0SAkSdsXol4wpscnoGieMI 2tuW6XT0bIDduyW/ApEo6yOeBuNXlE+4Wt/8XbkfTWaiwPo9qJR9vVKVIioSuy0hKygb x0157fqpGBmy5oAoXCymPgvdfM4NEBNr3GohDi8rRM+oTzahDTKhkkdO3n+99gf1+LIX j2OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769774158; x=1770378958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+WZkU1lyCaEeWQ3hXRLyOfKOv0thvYXR823k7SIXJtQ=; b=l91d90sDTRKT0ERkx1VVVdOWtxeh80Y3IohJ5eG/sxFN7VHTaYHtSCQjj1uek+u3WA fRqq2pxtP0KeU5WqJAF+ZdFxWjG0zEP3JXdF5eGnikyR2IHS/Euil8shxP+EhlyL9CsI g5ebE+3V9p48JzVch9U+IsHYptVgLtQ2hD3p2MRcNItfgo9m0s5tCdRIPRLRYJ4Ku6L5 bDStWnBDQT4YwgpO2sfv/dmBMv3XusbDRluVRHtX4N0FmooxPiek3fVu3q5/cuopwsdf 7Crke2BP5tw1nuowil7/MiVO0jY9Rn6dPA94lFKxsGSEpQvxV++P/URZDNBawP+9BzxT QAxA== X-Forwarded-Encrypted: i=1; AJvYcCUjRsp/NSlPS6G7f+VCBZtFVmdGYgtVbusa2MoneOYp5/wrUdUflIcVQ+irPAbVg9UT1WrP3AlMbI+e8Ok=@vger.kernel.org X-Gm-Message-State: AOJu0YzdkAaMhw1z3Z6o+Dn+DUcl3rd18lE7mn9t21H43yuM/rv2mZ/o W/KubCDFgZKxEz3TWUq/CxU/WDlxuTMBys7sWRqdwrQpZ6EoNFzA702TeblWUGH3zUGeQ3bpPes JPLtki+grK+zQKciOQygUeDfCzaaBR1BzZXGvR6HCbRlmS12i3R9H51KGOXwzCgfVuvg= X-Gm-Gg: AZuq6aK2P8eV1HhdRSUz6uCduxsOyUYjjacodOYJLa6nJw0PkY1ao0epsfvTFs/bPvP mc08BgvbqCpc7HpUI8NLTTiHrKOnF0bPYSn6fDhPpwNVOlzKhwhUHlK1QARw/qrXCVb0aVrhyLy 59F3TsGomzxl6vk6wzorjJdQQxLTx8teM2kbUGafimiQUpN6ehcdGK/C3NCmYjYthDXFoelf2xx iChiZVcWbASVh0RWa6za/g+FiBeca2/Kg9jvoY4msM92VbKbsYSg4wlv4J+1BVX1z5xSoGmNZOs eg9ReAR/nTq5SRiJX3oivQ3mZWr4h8/IJRAW3PL2y4uoOjiZLkF2h9kG0LNCo8VOjTpiPWPxVzo KVxRoWCys8Rm6DIR+ntHsww1RHpECOOIJb6Q+yLnEtXF7HLSO4sa9GgJ60TpvNBgwdWI= X-Received: by 2002:a05:6214:4f01:b0:894:946e:3687 with SMTP id 6a1803df08f44-894ea096a36mr24616276d6.7.1769774157960; Fri, 30 Jan 2026 03:55:57 -0800 (PST) X-Received: by 2002:a05:6214:4f01:b0:894:946e:3687 with SMTP id 6a1803df08f44-894ea096a36mr24616086d6.7.1769774157533; Fri, 30 Jan 2026 03:55:57 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4256a4bsm4118791a12.2.2026.01.30.03.55.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 03:55:57 -0800 (PST) Message-ID: <2697d1e1-8421-46aa-b58f-10608a2bea2c@oss.qualcomm.com> Date: Fri, 30 Jan 2026 12:55:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: ice: Avoid probe deferring for un-supported ICE feature To: Sumit Garg Cc: Rob Herring , linux-arm-msm@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, abelvesa@kernel.org, mani@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg References: <20260130091118.147379-1-sumit.garg@kernel.org> <4ad700f3-da8f-4175-9172-3fc4d87d8152@oss.qualcomm.com> <4f629971-94cb-44aa-9502-4f5ebfd63937@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _TUr7_oqsIR7Ci_M9B5Ud-1g7pnuaAek X-Proofpoint-ORIG-GUID: _TUr7_oqsIR7Ci_M9B5Ud-1g7pnuaAek X-Authority-Analysis: v=2.4 cv=d6T4CBjE c=1 sm=1 tr=0 ts=697c9c4e cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=9oxdx14C3Cyt1g6qQDsA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA5NyBTYWx0ZWRfX+CPmfu8Umh72 OSCGczIkpEtf4noM6pUhJFcLrdPWCahq7ZeQEzIbKfiQ8t6mM1rrfOvMXesi6ilR4PCZumuiFrF JICPrZckvHbyXrN0wI6SE6pUcC3FS+YpGiIlsWYBHVMvDdXxxBuJc2XA3i57IMz7L1Lb4kLCpcf I93hG6VYZnPqLWX0sweoQwsPajwTZny0TlB2YAm6iEgxkruxE/N+V6tECkBYddrcTvFCY4gIe5O /UdPnfz0vl2h21sD8b/e3jq2RO2LaL3X8F26nE1AroOzITkN21+raOf55YZxXV2NNBP32T3BnnB 6QRh9EEcK9DFGj9yBw/nnVHehdF4H6QTs86aLMPiN2mVA/1Hre9EbBY329jGEbCsNWG1YMAxxiR I67XLs7djDilJkR+TmH0vT3JYR3SFnbFOmM2PJe3wezmOSanT3N3PLVg0ipotb1tNy7PE7vhM51 uDr/dOKMHrBnDAOrZvQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_01,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300097 On 1/30/26 12:36 PM, Sumit Garg wrote: > On Fri, Jan 30, 2026 at 10:59:18AM +0100, Konrad Dybcio wrote: >> On 1/30/26 10:52 AM, Sumit Garg wrote: >>> On Fri, Jan 30, 2026 at 10:34:26AM +0100, Konrad Dybcio wrote: >>>> On 1/30/26 10:11 AM, Sumit Garg wrote: >>>>> From: Sumit Garg [...] >>> Since qcom,ufs depends on qcom,ice via a phandle, so isn't the probe >>> orderering automatically taken care off? Or that isn't the case here? >> >> No, that's guaranteed by devlink only with certain properties. > > Okay I see. The other alternate solution I can come up is following to > keep the deferred probing intact. Let me know your thoughts on this: > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index ab9586b8caf5..76bf9f94fbaf 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -559,7 +559,7 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > > if (!qcom_scm_ice_available()) { > dev_warn(dev, "ICE SCM interface not found\n"); > - return NULL; > + return ERR_PTR(-ENODEV); > } > > engine = devm_kzalloc(dev, sizeof(*engine), GFP_KERNEL); > @@ -648,11 +648,14 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev) > } > > ice = platform_get_drvdata(pdev); > - if (!ice) { > + if (IS_ERR_OR_NULL(ice)) { > dev_err(dev, "Cannot get ice instance from %s\n", > dev_name(&pdev->dev)); > platform_device_put(pdev); > - return NULL; > + if (PTR_ERR(ice) == -ENODEV) > + return NULL; > + else > + return ERR_PTR(-EPROBE_DEFER); > } > > link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER); > @@ -726,7 +729,7 @@ static int qcom_ice_probe(struct platform_device *pdev) > } > > engine = qcom_ice_create(&pdev->dev, base); > - if (IS_ERR(engine)) > + if (IS_ERR(engine) && PTR_ERR(engine) != -ENODEV) > return PTR_ERR(engine); > > platform_set_drvdata(pdev, engine); This looks more robust. Although the UFS and MMC drivers today check for EOPNOTSUPP, so perhaps throwing that would be even better > >> In this case though, I think it could make sense to add it to the >> "suppliers" list in drivers/of/property.c. >> >> I don't know if vendors adding their custom properties there is a >> pattern that +Rob will be happy about though.. > > Not sure if that's a shorter path as I would like to see fix for this > issue backported as well. > > Aside, not sure how much stable ICE feature itself is as I got following > crash with QLI boot firmware on Kodiak: > > [ 5.172970] SError Interrupt on CPU6, code 0x00000000be000000 -- SError > [ 5.172986] CPU: 6 UID: 0 PID: 241 Comm: (udev-worker) Tainted: G M 6.19.0-rc5-next-20260115-gc1a0fee87a05 #9 PREEMPT > [ 5.172996] Tainted: [M]=MACHINE_CHECK > [ 5.172999] Hardware name: Qualcomm Technologies, Inc. Robotics RB3gen2 (DT) > [ 5.173003] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 5.173010] pc : qcom_ice_create.part.0+0x6c/0x24c [qcom_ice] > [ 5.173024] lr : qcom_ice_create.part.0+0xe4/0x24c [qcom_ice] Could you please decode the pc value with ./scripts/faddr2line? My compiler produces different output ./scripts/faddr2line vmlinux(or path to .ko) Konrad