From: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
To: Sumit Gupta <sumitg@nvidia.com>,
rafael@kernel.org, viresh.kumar@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, treding@nvidia.com,
jonathanh@nvidia.com, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: bbasu@nvidia.com, Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Subject: Re: [PATCH v3 0/9] cpufreq: tegra194: add Tegra264 support
Date: Thu, 19 Nov 2026 19:41:34 +0800 [thread overview]
Message-ID: <2698e091-17e9-4a1d-acf1-19981ee604da@oss.qualcomm.com> (raw)
In-Reply-To: <20261119111217.902071-1-sumitg@nvidia.com>
On 11/19/2026 7:12 PM, Sumit Gupta wrote:
> This series adds cpufreq support for Tegra264, which joins the SoCs
> already supported by the tegra194-cpufreq driver.
>
> Tegra264 keeps the existing model, where BPMP provides the NDIV limits.
> The driver derives the current frequency from the core clock and
> reference counters.
>
> The main differences are:
> - Frequency read: through system registers, as on Tegra194, but from
> the 64-bit architected AMU counters. The reference counter ticks at
> the system counter rate (CNTFRQ).
>
> - Frequency request: through MMIO, as on Tegra234. The driver writes
> NDIV to a core_freq_req register in the CCPLEX register space. Each
> register controls a clock shared by two single-CPU clusters, so both
> CPUs form one cpufreq policy.
>
> The patches fall into four groups:
> - Fix (patch 1): read each CPU's MPIDR from a CPU hotplug callback
> instead of at probe. A CPU that is offline at probe then also gets
> valid cluster and core IDs.
>
> - Preparation (patches 2 to 5): cleanups, mostly of the counter code,
> to make room for a 64-bit counter and for an MMIO mapping without
> ACTMON counters.
>
> - Improvement (patches 6 and 7): group CPUs by the generic
> "performance-domains" property, which cluster-based grouping cannot
> express on Tegra264. Device trees without it keep the existing
> grouping.
>
> - Tegra264 support (patches 8 and 9): the driver support, followed by
> the device tree changes it relies on.
>
> v2[2] -> v3:
> - Patch 8: read the AMU counters with interrupts disabled (Zhongqiu).
> - Add Reviewed-by from Zhongqiu to patches 1-7 and 9.
For patch 8/9:
Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
>
> v1[1] -> v2:
> - Patch 1: drop the cpu argument of get_cpu_cluster_id() (Zhongqiu).
> Check for a bad MPIDR in tegra194_get_speed() (Sashiko).
> - Patch 7: check the BPMP table in tegra194_get_speed() (Sashiko).
> - Patch 8: fail probe if AMU is not available (Zhongqiu).
>
> Sumit Gupta (9):
> cpufreq: tegra194: move MPIDR read to CPU hotplug callback
> cpufreq: tegra194: remove duplicate counter sampling loops
> cpufreq: tegra194: add tegra_counter_delta helper
> cpufreq: tegra194: add per-SoC counter mask
> cpufreq: tegra194: split MMIO mapping from ACTMON offset
> dt-bindings: arm: nvidia: Document the Tegra264 CCPLEX cluster
> cpufreq: tegra194: derive frequency domain from device tree
> cpufreq: tegra194: Add support for Tegra264
> arm64: tegra: Add CCPLEX cluster node for Tegra264
>
> .../tegra/nvidia,tegra-ccplex-cluster.yaml | 27 +-
> arch/arm64/boot/dts/nvidia/tegra264.dtsi | 21 +
> drivers/cpufreq/Kconfig.arm | 4 +-
> drivers/cpufreq/tegra194-cpufreq.c | 456 +++++++++++++-----
> 4 files changed, 387 insertions(+), 121 deletions(-)
>
> [1] v1: https://lore.kernel.org/lkml/20261104181521.3003578-1-sumitg@nvidia.com/
> [2] v2: https://lore.kernel.org/lkml/20261117154954.625126-1-sumitg@nvidia.com/
>
> base-commit: e8017d29067fd1310a65c3494ce1a1b492adbac6
--
Thx and BRs,
Zhongqiu Han
prev parent reply other threads:[~2026-11-19 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 11:12 Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 1/9] cpufreq: tegra194: move MPIDR read to CPU hotplug callback Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 2/9] cpufreq: tegra194: remove duplicate counter sampling loops Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 3/9] cpufreq: tegra194: add tegra_counter_delta helper Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 4/9] cpufreq: tegra194: add per-SoC counter mask Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 5/9] cpufreq: tegra194: split MMIO mapping from ACTMON offset Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 6/9] dt-bindings: arm: nvidia: Document the Tegra264 CCPLEX cluster Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 7/9] cpufreq: tegra194: derive frequency domain from device tree Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 8/9] cpufreq: tegra194: Add support for Tegra264 Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 9/9] arm64: tegra: Add CCPLEX cluster node " Sumit Gupta
2026-11-19 11:41 ` Zhongqiu Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2698e091-17e9-4a1d-acf1-19981ee604da@oss.qualcomm.com \
--to=zhongqiu.han@oss.qualcomm.com \
--cc=bbasu@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®