From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FEDEC433EF for ; Mon, 25 Apr 2022 17:31:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243991AbiDYRec (ORCPT ); Mon, 25 Apr 2022 13:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238514AbiDYReb (ORCPT ); Mon, 25 Apr 2022 13:34:31 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4121583A2; Mon, 25 Apr 2022 10:31:24 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id w16so9751600ejb.13; Mon, 25 Apr 2022 10:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lx7n01ak613wao/PeGm56R/NraVbxP43cN5ZMlrScAY=; b=AWomtSHBSdpy50i/AiQTF1zEO67p6sM2bAacCXCIrE1EI3drNnFByVmoCM0R/JmKoO 9gRqHx/Jriy3h41XZP3C0mqTsYL8gZMgJtK5YGBcBAM13cfn2MrAbHZu+63WnkD3pA0M DlNSX4/BDpYDhYNLxlybbm4UpTRPqmYx6mc07No5+cFKexLhyMCE/gp0T9Y5ncFf9UlH 4t+iuhsW2AwBCXq8A0RuQ0hp4vsOhB/eDpAaHSKVH5lGxCZa6y2yaOCbBcLTm58dwi5j 2mokqtKMGMcjlCu7ZnzTM9o/NOIptNtADfUmrdCmKHoADrK3HZRdkAov3SEu1yD6nH7F 2pNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lx7n01ak613wao/PeGm56R/NraVbxP43cN5ZMlrScAY=; b=yWaRFSJ4t1V7Q49cde4pYMMv83Ld2nWxCRXiwgtdeRmlRF2wUnNS7CsJ2q3tOrfAqK 8ZfO85p+EuhzFYnTSpB2HAqVtQfVhRCphB0OhnjX/CUycBvYU10wZU9WSYhMBwuVbVaH xbu3eQyNvmHSticVzD5ZRNsgC3eIET0s1BaS89Fiya7BPMzrXu0hfwz6mZQB+zu2Vd8p aYZZ6YetqoA0BbdylwKaUlHVzkUe0/d7ToTV1ha+pLD1uC/4C2Np4QT8PEnYDfmuRg0J XoGYsKDbEXjyGGO0whsQ00vGuCWHSLwHUhUzGlqcQiZ056FsQhxxDLajlunr8QlYfLcp ahFg== X-Gm-Message-State: AOAM532W6UEKmkjKrz4Ls9t4DiZf1NCfJ00SBXNyT1PHD0v9zkeLnNR6 6hJ4tqpi2zzJXOZ7K30cV2c= X-Google-Smtp-Source: ABdhPJxvwSr3XtyRkaaNJxbkUJVkHfpHdLP+s0Vc1yhmamJDJWKzG5omORC7vSs528rfOCd348xwnw== X-Received: by 2002:a17:907:6289:b0:6e0:eb0c:8ee7 with SMTP id nd9-20020a170907628900b006e0eb0c8ee7mr16442680ejc.245.1650907883149; Mon, 25 Apr 2022 10:31:23 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id r19-20020a17090638d300b006d6e4fc047bsm3884297ejd.11.2022.04.25.10.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 10:31:22 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Christophe JAILLET , Chen-Yu Tsai , Mark Brown , Maxime Ripard , Arnd Bergmann , Olof Johansson , Samuel Holland Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create() Date: Mon, 25 Apr 2022 19:31:21 +0200 Message-ID: <2699804.BEx9A2HvPv@kista> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne sobota, 23. april 2022 ob 21:39:45 CEST je Samuel Holland napisal(a): > On 4/21/22 9:35 AM, Christophe JAILLET wrote: > > This code is really spurious. > > It always returns an ERR_PTR, even when err is known to be 0 and calls > > put_device() after a successful device_register() call. > > > > It is likely that the return statement in the normal path is missing. > > Add 'return rdev;' to fix it. > > Thanks for the patch. This definitely looks to be the case. > > > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus") > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Samuel Holland > Tested-by: Samuel Holland > Applied to sunxi/fixes-for-5.18, thanks! Best regards, Jernej