From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7728E6BB4E for ; Thu, 16 May 2024 13:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715865708; cv=none; b=dzaCCOhVTdgjT3wGRpIJiTPy0BBWv0m89NL5I+DC82AqRDpED7M5692j5qBsRFC9/2pbAPBPaiiH/t0TSkUtUqjtWh4M+OIIpY45cy8WyJVDjAnGlaGhnXO4TuDCj0MyY6dRv14Rw/2ikQH+i19PfQ9RfSQFtzlv2cUHsk/PbBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715865708; c=relaxed/simple; bh=Ktri3O+y1JiTtE3Cd6eQ+A0O7nMjt46pOkSdqwviEaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Vlm3Ydo8PDY5emrLOKN4hi8rQpr40d0gCzuM+LqHQmXkGZCEEQXotwJ7d68Tv8+1oHRaICIUILAQYsUaPw+kLRfZcP5B76Kd38Us0eYin/v1yf8XYFIxnwwPTEqM+1ySr+o4OIYi3qT8kxlmHdcZULthKi8FChriVBcr7Aed5zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=P0SF3w0u; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="P0SF3w0u" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2e428242a38so9797821fa.2 for ; Thu, 16 May 2024 06:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1715865704; x=1716470504; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yrv6VISaglcxTRZ/0ZiSzXEYQeCVDXkyflKgtaSfATY=; b=P0SF3w0u3a+l7fTTDKSEKu6EFYWycGCuNei77XVOMoVdwar70SSZolCqX3wQ5DjSfo mQ+50x1chol0JtZX/wNuriJmNW80GEz/jU0BxjJOI5nNFpPJx8FLTyqcoE3XZDigBGZD vCqrJLRZmtUrYpr266fWAG/rBpJ8uBmWYgCOTBd9BFxIhI3OXGp6LI/q2tVCJMVbc67p mefFW3XFiLhz12ztEQSt62DM6wl9+JssmkmpTUIdNVrHPapVfYASNrztHlcC+bAYKaJJ 6yU3femh5vz3QhHpYF9Lv0TAUSR7htVg9GSpPRLsaZJXwiuhLTCY98rEUleRKyViDoWm 5oew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715865704; x=1716470504; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yrv6VISaglcxTRZ/0ZiSzXEYQeCVDXkyflKgtaSfATY=; b=eYGB154x1LE0gnvXJdeQbGDMw2ZCr4Neuaqba0fOFNBilXxa3AqXDpbeueUl5TlNJt N2mUcJ1LjRE7Vbg2/TpGUiYfOvtqWEr52+pg+1e0S+r+0gTL8sfc3UHWlTz9+zyVosaz YmxPvBDMyDWuHKw373n0eEhCODXvmDuYIK8Jt5IwoPP31hsuoEZKkzdvOLHT99kB6PP/ 4y69KOws67Ot+JObFdsAmwFt69fxM9BuJjgBBXJtXJZGC7zcEvYiTQniN2fX4gf9dJ2c P9ixgD2ZSrkIbqHRjFSYCS84bf2+prCfYMlWa9K6a2Mrjv/kjruXWw/uPYQLD3WjBQgt LoPw== X-Forwarded-Encrypted: i=1; AJvYcCUrWV3GNJL/N8PA8jfn8pzTznAYDakhMZPn0W0XOgoGAodkN2YulRIcMI/twv/aJsLhQwCAWcmUbt9ienLDYm08FQeGyqFqh2yyvSQA X-Gm-Message-State: AOJu0YyhMRZfAqDsP5G22vzOpLJ+o/b0RAEYG5Ups+nKr8/Bg4YYlP4O CZ8cEqPu2aH2QAYJGsX4sB7Pi8pzoZdThMK2k4oULm5yp3T0VJGljK3RYGrXCic= X-Google-Smtp-Source: AGHT+IGPzxjcYgd94UKow7Dij1TOsrAaSOrA+bVuaeThwzPzNBvd6EdpewP4a0WRZZ0zr9KYdakxCw== X-Received: by 2002:a2e:b385:0:b0:2e1:9c57:195a with SMTP id 38308e7fff4ca-2e52028921amr159361861fa.32.1715865704467; Thu, 16 May 2024 06:21:44 -0700 (PDT) Received: from [192.168.0.2] (host-79-16-6-145.retail.telecomitalia.it. [79.16.6.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41f882086f0sm306095145e9.42.2024.05.16.06.21.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 06:21:38 -0700 (PDT) Message-ID: <2699ec89-29a1-4b9d-b3ec-7792713041c4@baylibre.com> Date: Thu, 16 May 2024 15:20:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] dt-bindings: iio: dac: add ad35xxr single output variants To: Jonathan Cameron , David Lechner Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240510141836.1624009-1-adureghello@baylibre.org> <20240511170529.742e6e6f@jic23-huawei> Content-Language: en-US From: Angelo Dureghello In-Reply-To: <20240511170529.742e6e6f@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 11/05/24 6:05 PM, Jonathan Cameron wrote: > On Fri, 10 May 2024 10:39:31 -0500 > David Lechner wrote: > >> On Fri, May 10, 2024 at 9:19 AM Angelo Dureghello >> wrote: >>> From: Angelo Dureghello >>> >>> Add support for ad3541r and ad3551r single output variants. >>> >>> Signed-off-by: Angelo Dureghello >>> --- >>> .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml >>> index 8265d709094d..17442cdfbe27 100644 >>> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml >>> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml >> It would be nice to also add the datasheet links in the description. ack, >>> @@ -19,7 +19,9 @@ description: | >>> properties: >>> compatible: >>> enum: >>> + - adi,ad3541r >>> - adi,ad3542r >>> + - adi,ad3551r >>> - adi,ad3552r >>> >>> reg: >>> @@ -128,7 +130,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: adi,ad3542r >>> + enum: >>> + - adi,ad3541r >>> + - adi,ad3542r >>> then: >>> patternProperties: >>> "^channel@([0-1])$": >>> @@ -158,7 +162,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: adi,ad3552r >>> + enum: >>> + - adi,ad3551r >>> + - adi,ad3552r >>> then: >>> patternProperties: >>> "^channel@([0-1])$": >>> -- >>> 2.45.0.rc1 >>> >>> >> Since these are single channel, it would not hurt to restrict the >> `reg` property of of the `channel@` nodes to 1. ack, > Ah. I missed David's email because threading goes weird without a cover letter > and hence duplicated his comment. > Please add a cover letter with a brief description of the series to > your v2. Means we get a nice title in patchwork as well! > > Thanks, > > Jonathan > > Thanks for the feedbacks, will fix all in v2. Regards, angelo