From: Jason Yan <yanaijie@huawei.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<john.garry@huawei.com>, <damien.lemoal@wdc.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: aic94xx: Add missing check for dma_map_single
Date: Mon, 30 Jan 2023 21:31:21 +0800 [thread overview]
Message-ID: <269dc3a6-41d5-d608-afac-963a55265368@huawei.com> (raw)
In-Reply-To: <20230128110832.6792-1-jiasheng@iscas.ac.cn>
On 2023/1/28 19:08, Jiasheng Jiang wrote:
> Add check for dma_map_single and return error if it fails in order
> to avoid invalid dma address.
>
> Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/scsi/aic94xx/aic94xx_task.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/aic94xx/aic94xx_task.c b/drivers/scsi/aic94xx/aic94xx_task.c
> index ed119a3f6f2e..7f0208300110 100644
> --- a/drivers/scsi/aic94xx/aic94xx_task.c
> +++ b/drivers/scsi/aic94xx/aic94xx_task.c
> @@ -50,6 +50,9 @@ static int asd_map_scatterlist(struct sas_task *task,
> dma_addr_t dma = dma_map_single(&asd_ha->pcidev->dev, p,
> task->total_xfer_len,
> task->data_dir);
> + if (dma_mapping_error(&asd_ha->pcidev->dev, dma))
> + return -ENOMEM;
> +
> sg_arr[0].bus_addr = cpu_to_le64((u64)dma);
> sg_arr[0].size = cpu_to_le32(task->total_xfer_len);
> sg_arr[0].flags |= ASD_SG_EL_LIST_EOL;
>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
next prev parent reply other threads:[~2023-01-30 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 11:08 Jiasheng Jiang
2023-01-30 13:31 ` Jason Yan [this message]
2023-02-09 0:12 ` Martin K. Petersen
2023-02-14 16:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=269dc3a6-41d5-d608-afac-963a55265368@huawei.com \
--to=yanaijie@huawei.com \
--cc=damien.lemoal@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=jiasheng@iscas.ac.cn \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®