From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37802C47087 for ; Fri, 28 May 2021 08:26:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 141AD613DA for ; Fri, 28 May 2021 08:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236374AbhE1I1g (ORCPT ); Fri, 28 May 2021 04:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236366AbhE1I1d (ORCPT ); Fri, 28 May 2021 04:27:33 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EADFC06174A for ; Fri, 28 May 2021 01:25:50 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id f20-20020a05600c4e94b0290181f6edda88so4071605wmq.2 for ; Fri, 28 May 2021 01:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gmLVVcZ2N+hglXJfzP+ki9yu4ta4AFOaHMScj05dW+U=; b=YAoqpL3LdNFFopz1uasqeeJnfrbce4oZDKGeD6db3hOHwdYp53iI0duwXQPztv/GmE I4Hh2K/TgdG3sQ0vRDGJ9+Bs9YHQugHmPnachfpNqJMkKPxksAlUQ2NNN+lmSrk3cUZV 7VAgHwYTKt3ZhhNKuEON3ehfNGPv5svHxhundcdkdkoFl5DwSlf2MSV/R0bo9Zq3rIUo t1OamaJklC1WVQi2NNH3C8fDmCi+kiFqcv4Z38re8XgG5k9pgM4D2Trv0qksR/rSE0Wi fz8yLrSR0SeqAk2ruBTFnzRswveADYPx7UdhJIGBDeCkgqJkfnXGPIAENj4C3tO3uhLg ubcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gmLVVcZ2N+hglXJfzP+ki9yu4ta4AFOaHMScj05dW+U=; b=ZMJthTua5RUP2sFKIQN8vhy/y/aHPTdF+oRkTK9gvNdEL1Pnl3wNpXpl3WmH7nTOkl dwqvMQuqr/Na+zHHulleOkbsWZk0q9khwDTrWcup3mqSHW/1k8V7TC1hiNLbOQgWh2FP jHkJRHWUM5kTuRqgUr5FZmoc/u1IIgdQSY43V+Rn+7DT8wmZbiOHTgXML91sNZBE5BqR BR+MqoAMAwI0cBOIBNcZfNIyf6fPH3KmKNL4DSW9hsW7Nd3eEvj5skVUD5cA7vUCuOzz iO+9soNUmbVvKkvghu4myMvL1NJ17UnYLtcIpQbry+CM2hJ2mXpSbhuZOSLmPbtrUVVs /caA== X-Gm-Message-State: AOAM533Tv1Mn0xsNKRTHf6UbNECNzeKeTN+7OGBsLaFZ8omBN2sQZAaP rls2sZX4dnenDI/nc6/5GeLCw+8VXF97Rw== X-Google-Smtp-Source: ABdhPJx8E7fPHSUVSThV6qHpCVgZr326Eid66C+rC24e58hcLs6jPFnhaUX9sTcHUVNoyX9aVvHSDA== X-Received: by 2002:a05:600c:358f:: with SMTP id p15mr12336004wmq.14.1622190348852; Fri, 28 May 2021 01:25:48 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id 60sm6300907wrq.14.2021.05.28.01.25.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 May 2021 01:25:48 -0700 (PDT) Subject: Re: [PATCH 1/2] nvmem: core: constify nvmem_cell_read_variable_common() return value To: Douglas Anderson Cc: Rajendra Nayak , linux-arm-msm@vger.kernel.org, Stephen Boyd , Joe Perches , linux-kernel@vger.kernel.org References: <20210521140031.1.Ibaca694aedfaff823feefa06b29ae746c641dd1a@changeid> From: Srinivas Kandagatla Message-ID: <269ec480-e4b8-30c8-db3d-f45095fa1d46@linaro.org> Date: Fri, 28 May 2021 09:25:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210521140031.1.Ibaca694aedfaff823feefa06b29ae746c641dd1a@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/05/2021 22:00, Douglas Anderson wrote: > The caller doesn't modify the memory pointed to by the pointer so it > can be const. > > Suggested-by: Stephen Boyd > Signed-off-by: Douglas Anderson > --- > Applied both thanks, --srini > drivers/nvmem/core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index f9c9c9859919..4868aa876e1b 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -1609,9 +1609,9 @@ int nvmem_cell_read_u64(struct device *dev, const char *cell_id, u64 *val) > } > EXPORT_SYMBOL_GPL(nvmem_cell_read_u64); > > -static void *nvmem_cell_read_variable_common(struct device *dev, > - const char *cell_id, > - size_t max_len, size_t *len) > +static const void *nvmem_cell_read_variable_common(struct device *dev, > + const char *cell_id, > + size_t max_len, size_t *len) > { > struct nvmem_cell *cell; > int nbits; > @@ -1655,7 +1655,7 @@ int nvmem_cell_read_variable_le_u32(struct device *dev, const char *cell_id, > u32 *val) > { > size_t len; > - u8 *buf; > + const u8 *buf; > int i; > > buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len); > @@ -1686,7 +1686,7 @@ int nvmem_cell_read_variable_le_u64(struct device *dev, const char *cell_id, > u64 *val) > { > size_t len; > - u8 *buf; > + const u8 *buf; > int i; > > buf = nvmem_cell_read_variable_common(dev, cell_id, sizeof(*val), &len); >