mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: vit9696 <vit9696@protonmail.com>
To: Alessio Ferri <alessio.ferri@mythread.it>
Cc: "Rafał Miłecki" <zajec5@gmail.com>, "Michael Buesch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org
Subject: Re: [PATCH wireless-next v2 3/8] bcma: pcie2: request HT on BCM4352/BCM4360
Date: Wed, 28 Oct 2026 11:40:57 +0000	[thread overview]
Message-ID: <26B3AF24-FF4C-41A8-8546-8B79FC9C30F2@protonmail.com> (raw)
In-Reply-To: <20261027-bcma-ac-rev1-v2-3-b69b61c31920@mythread.it>

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

This should apply for all revisions below 4, not just 3 as per open-source Broadcom driver[1].

Best,
Vitaly

[1] https://github.com/RMerl/asuswrt-merlin.ng/blob/ca72a61f8bc5ef920e29d63d53d9864262208f0c/release/src-rt-5.02axhnd.675x/bcmdrivers/broadcom/net/wl/impl69/main/src/shared/hndpmu.c#L2059-L2067

> On 27 Oct 2026, at 02:53, Alessio Ferri <alessio.ferri@mythread.it> wrote:
> 
> Set HAVEHTREQ in the PCIe2 core's clock control on chip rev 3, as
> Broadcom's driver does.
> 
> Signed-off-by: Alessio Ferri <alessio.ferri@mythread.it>
> ---
> drivers/bcma/driver_pcie2.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c
> index cf889fc62..fd8fab982 100644
> --- a/drivers/bcma/driver_pcie2.c
> +++ b/drivers/bcma/driver_pcie2.c
> @@ -170,6 +170,9 @@ void bcma_core_pcie2_init(struct bcma_drv_pcie2 *pcie2)
> case BCMA_CHIP_ID_BCM4360:
> case BCMA_CHIP_ID_BCM4352:
> pcie2->reqsize = 1024;
> + if (ci->rev == 3)
> + pcie2_set32(pcie2, BCMA_CLKCTLST,
> +    BCMA_CLKCTLST_HAVEHTREQ);
> break;
> default:
> pcie2->reqsize = 128;
> 
> --
> 2.34.1
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 583 bytes --]

  reply	other threads:[~2026-10-28 11:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 23:53 [PATCH wireless-next v2 0/8] bcma-ac-rev1: support 4352/4360 rev3 chips Alessio Ferri
2026-10-26 23:53 ` [PATCH wireless-next v2 1/8] bcma: core: clear only FORCEHT for BCMA_CLKMODE_DYNAMIC Alessio Ferri
2026-10-26 23:53 ` [PATCH wireless-next v2 2/8] bcma: pmu: init PLL and resources on BCM4352/BCM4360 Alessio Ferri
2026-10-28  0:44   ` vit9696
2026-10-28  9:14     ` Alessio Ferri
2026-10-28 13:34       ` vit9696
2026-10-26 23:53 ` [PATCH wireless-next v2 3/8] bcma: pcie2: request HT " Alessio Ferri
2026-10-28 11:40   ` vit9696 [this message]
2026-10-26 23:53 ` [PATCH wireless-next v2 4/8] bcma: chipcommon: enable asynchronous GPIO interrupts Alessio Ferri
2026-10-26 23:53 ` [PATCH wireless-next v2 5/8] bcma: extract SPROM revision 11 Alessio Ferri
2026-10-26 23:53 ` [PATCH wireless-next v2 6/8] firmware: bcm47xx_sprom: read ledbh4..ledbh15 from NVRAM Alessio Ferri
2026-10-28 12:43   ` vit9696
2026-10-26 23:53 ` [PATCH wireless-next v2 7/8] firmware: bcm47xx_sprom: read boardflags3 and AvVmid_c0..2 " Alessio Ferri
2026-10-28 13:27   ` vit9696
2026-10-26 23:53 ` [PATCH wireless-next v2 8/8] bcma: add the BCM4352 PCI ID Alessio Ferri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26B3AF24-FF4C-41A8-8546-8B79FC9C30F2@protonmail.com \
    --to=vit9696@protonmail.com \
    --cc=alessio.ferri@mythread.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®