From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02881BD9E5 for ; Tue, 14 Jan 2025 07:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736840050; cv=none; b=m1xAaxjN83bK6P5WAK5sC5vSuY28RlAnElIXabzbkr2MiGQgwH7AKDeyNZBqH9Vbkq9oecPwPIGwf9fjmQYUOILGR/WFTO69S9Up7TGi8rljCK6Ii6+YlltP387f6tzBK1FuZDioLJKbcrGfDsEE77RTKng/fROXBWbK5VsY0JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736840050; c=relaxed/simple; bh=fkURmCwU5E/XsaNLIiFfQVG1gdFc5wMQ2KsKB1ZcJ2o=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=cSgok2Q5eZ6h5U5U6RK6Rdu2dyrfO0mqxHj6QuiEaYNzh/Z75GvB2tBz+ceSDP75T9pzt8dRuJgOKQ2fs7Ut/o20VrlZhKlEp//4s7d5l4Qt7IXOhSGnQYw7FnX3MXGZewOEYzJOnWTISMmR0bi2puz582RuEM5hHiBxZLUcOhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NvbdhaVz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NvbdhaVz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E61CC4CEDD; Tue, 14 Jan 2025 07:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736840050; bh=fkURmCwU5E/XsaNLIiFfQVG1gdFc5wMQ2KsKB1ZcJ2o=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=NvbdhaVzOhoxso3gWQc8szw2qh88vniW2QIaMIUY8Tq1ayguQco1tNgEtRfYuI20k IPFMWU1HJ9qPlOTxlwjLT0YbY3jXgAvywurVMWbio+hb62DfY5zc8oPZ+EOPY5JPj0 nij3EzH/D5O/j4j4J56NvjHfLbvlqsAc6bUq2GXNBQr+rzWGMt3jDoYeAxJf5I+ieC PgCbguhmgRJBdOm7riYGsvriPs3d2EWTU8z7RAxumloUPlJWEvdFEWzwOsZ9mQRWvz aGH8xu/pkjlKomixO0tk9ADsWejmi4mZq8ycz6gzROuzCpvvw1aq8+XUvliaCRlnVd FvoCjN/ybdT6A== Message-ID: <26a1b409-11a1-48d8-9c2e-4213218baf15@kernel.org> Date: Tue, 14 Jan 2025 15:34:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: add a sysfs entry to request donate file-backed pages To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20250113183933.1268282-1-jaegeuk@kernel.org> <20250113183933.1268282-2-jaegeuk@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: <20250113183933.1268282-2-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/25 02:39, Jaegeuk Kim via Linux-f2fs-devel wrote: > 1. ioctl(fd1, F2FS_IOC_DONATE_RANGE, {0,3}); > 2. ioctl(fd2, F2FS_IOC_DONATE_RANGE, {1,2}); > 3. ioctl(fd3, F2FS_IOC_DONATE_RANGE, {3,1}); > 4. echo 3 > /sys/fs/f2fs/blk/donate_caches > > will reclaim 3 page cache ranges, registered by #1, #2, and #3. > > Signed-off-by: Jaegeuk Kim > --- > Documentation/ABI/testing/sysfs-fs-f2fs | 7 +++++++ > fs/f2fs/f2fs.h | 4 ++++ > fs/f2fs/shrinker.c | 27 +++++++++++++++++++++++++ > fs/f2fs/sysfs.c | 8 ++++++++ > 4 files changed, 46 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-fs-f2fs b/Documentation/ABI/testing/sysfs-fs-f2fs > index 3e1630c70d8a..6f9d8b8889fd 100644 > --- a/Documentation/ABI/testing/sysfs-fs-f2fs > +++ b/Documentation/ABI/testing/sysfs-fs-f2fs > @@ -828,3 +828,10 @@ Date: November 2024 > Contact: "Chao Yu" > Description: It controls max read extent count for per-inode, the value of threshold > is 10240 by default. > + > +What: /sys/fs/f2fs//donate_caches > +Date: December 2024 > +Contact: "Jaegeuk Kim" > +Description: It reclaims the certian file-backed pages registered by > + ioctl(F2FS_IOC_DONATE_RANGE). > + For example, writing N tries to drop N address spaces in LRU. > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 7ce3e3eab17a..6c434ae94cb1 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -1635,6 +1635,9 @@ struct f2fs_sb_info { > unsigned int warm_data_age_threshold; > unsigned int last_age_weight; > > + /* control donate caches */ > + unsigned int donate_caches; > + > /* basic filesystem units */ > unsigned int log_sectors_per_block; /* log2 sectors per block */ > unsigned int log_blocksize; /* log2 block size */ > @@ -4256,6 +4259,7 @@ unsigned long f2fs_shrink_count(struct shrinker *shrink, > struct shrink_control *sc); > unsigned long f2fs_shrink_scan(struct shrinker *shrink, > struct shrink_control *sc); > +void f2fs_donate_caches(struct f2fs_sb_info *sbi); > void f2fs_join_shrinker(struct f2fs_sb_info *sbi); > void f2fs_leave_shrinker(struct f2fs_sb_info *sbi); > > diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c > index 83d6fb97dcae..a3e2063392a7 100644 > --- a/fs/f2fs/shrinker.c > +++ b/fs/f2fs/shrinker.c > @@ -130,6 +130,33 @@ unsigned long f2fs_shrink_scan(struct shrinker *shrink, > return freed; > } > > +void f2fs_donate_caches(struct f2fs_sb_info *sbi) > +{ > + struct inode *inode = NULL; > + struct f2fs_inode_info *fi; > + int nfiles = sbi->donate_caches; > +next: > + spin_lock(&sbi->inode_lock[DONATE_INODE]); > + if (list_empty(&sbi->inode_list[DONATE_INODE]) || !nfiles) { > + spin_unlock(&sbi->inode_lock[DONATE_INODE]); > + return; > + } > + > + fi = list_first_entry(&sbi->inode_list[DONATE_INODE], > + struct f2fs_inode_info, gdonate_list); > + list_move_tail(&fi->gdonate_list, &sbi->inode_list[DONATE_INODE]); Not needed to drop it from the global list, right? Thanks, > + inode = igrab(&fi->vfs_inode); > + spin_unlock(&sbi->inode_lock[DONATE_INODE]); > + > + if (inode) { > + invalidate_inode_pages2_range(inode->i_mapping, > + fi->donate_start, fi->donate_end); > + iput(inode); > + } > + if (nfiles--) > + goto next; > +} > + > void f2fs_join_shrinker(struct f2fs_sb_info *sbi) > { > spin_lock(&f2fs_list_lock); > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > index 6b99dc49f776..7570580ec3c0 100644 > --- a/fs/f2fs/sysfs.c > +++ b/fs/f2fs/sysfs.c > @@ -811,6 +811,12 @@ static ssize_t __sbi_store(struct f2fs_attr *a, > return count; > } > > + if (!strcmp(a->attr.name, "donate_caches")) { > + sbi->donate_caches = min(t, sbi->ndirty_inode[DONATE_INODE]); > + f2fs_donate_caches(sbi); > + return count; > + } > + > *ui = (unsigned int)t; > > return count; > @@ -1030,6 +1036,7 @@ F2FS_SBI_GENERAL_RW_ATTR(max_victim_search); > F2FS_SBI_GENERAL_RW_ATTR(migration_granularity); > F2FS_SBI_GENERAL_RW_ATTR(migration_window_granularity); > F2FS_SBI_GENERAL_RW_ATTR(dir_level); > +F2FS_SBI_GENERAL_RW_ATTR(donate_caches); > #ifdef CONFIG_F2FS_IOSTAT > F2FS_SBI_GENERAL_RW_ATTR(iostat_enable); > F2FS_SBI_GENERAL_RW_ATTR(iostat_period_ms); > @@ -1178,6 +1185,7 @@ static struct attribute *f2fs_attrs[] = { > ATTR_LIST(migration_granularity), > ATTR_LIST(migration_window_granularity), > ATTR_LIST(dir_level), > + ATTR_LIST(donate_caches), > ATTR_LIST(ram_thresh), > ATTR_LIST(ra_nid_pages), > ATTR_LIST(dirty_nats_ratio),