From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EB8C5B579 for ; Fri, 28 Jun 2019 03:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67282208CB for ; Fri, 28 Jun 2019 03:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727217AbfF1DvJ (ORCPT ); Thu, 27 Jun 2019 23:51:09 -0400 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]:57719 "EHLO smtp2207-205.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbfF1DvJ (ORCPT ); Thu, 27 Jun 2019 23:51:09 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07491465|-1;CH=green;DM=CONTINUE|CONTINUE|true|0.348959-0.0103707-0.64067;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03299;MF=liaoweixiong@allwinnertech.com;NM=1;PH=DS;RN=13;RT=13;SR=0;TI=SMTPD_---.Er3LMMF_1561693861; Received: from 172.16.10.102(mailfrom:liaoweixiong@allwinnertech.com fp:SMTPD_---.Er3LMMF_1561693861) by smtp.aliyun-inc.com(10.147.42.16); Fri, 28 Jun 2019 11:51:02 +0800 Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips To: Miquel Raynal , Schrempf Frieder Cc: Greg KH , Vignesh Raghavendra , Boris Brezillon , Richard Weinberger , "linux-kernel@vger.kernel.org" , Chuanhong Guo , Marek Vasut , "linux-mtd@lists.infradead.org" , "stable@vger.kernel.org" , Brian Norris , David Woodhouse References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> <20190627190644.25aaaf31@xps13> <20190627201742.34059cdf@xps13> From: liaoweixiong Message-ID: <26a4597e-3881-73a2-07e3-6171ddd15d51@allwinnertech.com> Date: Fri, 28 Jun 2019 11:51:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190627201742.34059cdf@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On 2019/6/28 AM2:17, Miquel Raynal wrote: > Hi Miquel, > > Miquel Raynal wrote on Thu, 27 Jun 2019 > 19:06:44 +0200: > >> Hello, >> >> Schrempf Frieder wrote on Tue, 25 Jun >> 2019 07:04:06 +0000: >> >>> Hi liaoweixiong, >>> >>> On 25.06.19 05:08, Greg KH wrote: >>>> On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: >>>>> In case of the last page containing bitflips (ret > 0), >>>>> spinand_mtd_read() will return that number of bitflips for the last >>>>> page. But to me it looks like it should instead return max_bitflips like >>>>> it does when the last page read returns with 0. >>>>> >>>>> Signed-off-by: liaoweixiong >> >> Please write your entire official first/last name(s) >> OK. >>>>> Reviewed-by: Boris Brezillon >>>>> Reviewed-by: Frieder Schrempf >> >> I am waiting your next version with Acked-by instead of Rewieved-by >> tags and Greg's comment addressed. > > Sorry for the mistake, R-b tags are fine here, don't touch that. > The rest needs to be fixed though. > OK. >>>>> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") >> >> Finally, when we ask you to resend a patch, it means sending a new >> version of the patch. So in the subject, you should not use the >> [RESEND] keyword (which means you are sending something again exactly >> as it was before, you just got ignored, for example) but instead you >> should increment the version number (v3) and also write a nice >> changelog after the three dashes '---' (will be ignored by Git when >> applying). >> >> I would like to queue this for the next release so if you can do it >> ASAP, that would be great. >> I will do it right now. >> Thank you, >> Miquèl > > > > > Thanks, > Miquèl > -- liaoweixiong