From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753552AbcIIQVX (ORCPT ); Fri, 9 Sep 2016 12:21:23 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:58263 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753083AbcIIQVR (ORCPT ); Fri, 9 Sep 2016 12:21:17 -0400 Subject: Re: [PATCH 3/5] nbd: use flags instead of bool To: Joe Perches , Josef Bacik , , , , , References: <1473369130-22986-1-git-send-email-jbacik@fb.com> <1473369130-22986-4-git-send-email-jbacik@fb.com> <1473384038.13672.23.camel@perches.com> <1473437068.13672.41.camel@perches.com> <9ddc6c54-72cd-b3d4-d7f3-f96dc33164fc@fb.com> <1473437700.13672.43.camel@perches.com> From: Jens Axboe Message-ID: <26a66a56-2d37-4945-ec68-72f33f203bdd@fb.com> Date: Fri, 9 Sep 2016 10:20:47 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473437700.13672.43.camel@perches.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: CO1PR15CA0022.namprd15.prod.outlook.com (10.166.26.160) To BN6PR15MB1187.namprd15.prod.outlook.com (10.172.205.141) X-MS-Office365-Filtering-Correlation-Id: 0a76f185-75fe-4ef9-9dd6-08d3d8cd4514 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;2:7+WUcnNaf0Y0LIme54Yr/WsaWcFh6KpjxXTkoR6bPGgnLIYpCQA37c8vHfNjsEYxXjs5mJGBIxYBs/B5dv94fvZESI+kMEYkrVVXJDXq/l525BIyR1mFhPhR7pUzyfYv0wg1d2J+hUVLHfaASRPTEeLqM82J4IsLEhq7cbfhDpuFtNfHhct4yWl3t0xAeUel;3:xzJOmomgzkDoE94qFj80LHDDij6zLttwP4koyxqlqmYdhPyt/uICW3I2SshhvXdFunKZFeCz7hB06wMJWKnRFnv7c7Jl2bgA02r5f5EVIp/f21l9iwln4jfbQUFGPITD X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;25:VEnpce/KGBepQxcZ/3w1BY13jyXJDgkShohZmgjFb9E/BrVcrs/KSxRhXFNctpZxQrojd/l+K35NunHOyEq3HkVP4N/5tKOqiZzV/5h8x/a3+wzWBaY5zsoRUkV5li9FECWDL/buQKawDL3jnm3yPCu1WmHrbS8MNIdj/e/NcNggkaoNFEXYv3xhZA8y34VBFukyKPbpT4ZV0b8d2aazNvqWEAE1fJ50m1J4UIaNdoWm+Foj/VMlJadwEZq5Qxa0U4RUETye96/iOm3GdInQ3Ad+e8Hh8HhCKaSfmgyV54+c9d7Wr5y3wLDJK7GP0CZ1C7vVOffcAcXzo2QkGT6ZT1j1bL60EUT0CJbgsnXHTWSNNTLZvVkl1YSsg4zAKpesxt9Wp+d4BMmXXtM+MS8H4KW1T0eZuvOU4YEj8doNgk80wgCuQJIBpPd+mNR7xoygHeDEY8lOhbjhPxjeL0Y/hDW8cll+bcJCuOi9ZwZuIHiqxDPhysXNcUt4im6evAfNkS1XE8/13Wc2J/M7uVp8F0X71ZVdq/IhvmKiAOXQBfr6QAiZKxSdUMwgsHOSzGiHnntcQ5gO+ZJeBiG91MdB3jEQp3CbMFhwlfo+fPLrtQrCM3xyLH42o87Dgf3+yqZTBuW3JF3bQFEQhgAgoosY6oVb5yoVqNcK7WVJ2iktK2P01GLvtOAlAsxsXixpp9aO;31:Jikr0disraOYcW293zM18griHwgLzxfRmeUWGC4vV3YvLnxNy0NQOnFiL9HTnnujFlVPN2Wkz0Bh90HFuMF3vPkdgoG2stc5bwiZX+8/6AEaYQ2NEq4tTbOsDgCQ3yfLP0+tuOI6KHW7X2ywRVT9J5sam0+1wsA7c44n5rnFBaBBTzK+jYUxqj/AcVwuP4vUl66IyIozrRsEox2Wb34OWGZNcQ5nA7SwIDSQH4T9ckI= X-LD-Processed: 8ae927fe-1255-47a7-a2af-5f3a069daaa2,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:+BEilwgOmFaoiQ/t4KzbKb9HxIAVDws3O/XFzOJKCOPSShmx1AjinnTg4MwXwRcJGkcOQgrEuQfxIPqKDgsKEWJ7wd0DRG3AxDTWIogudP+4qWJLRLG1Qb+Hqs9WmPuQlrCgZGWyX+37Lw307sDXWZW5qqCc+07AefoxX24MsCU=;4:nLuZmccvkzZ43LkCYRFDTKIgUGAxoHQT5sl+8+SoGGikMKFxWEkHHMA37MflmDfmyq74XOs6Gc9PUzsGojzoF1CvUWUb4Bud+CDISF6z1Fyt3sufOawRG/3B71qJSvcTIGiJM22dtXYyaGAPuUSZ0k0654q57RrI7GTPRhkw68kuysSRyeEKFTYoBxH8X6UZU+k4xgLBgJIPNmHY0ZREccFKh7sOLlFtvDgkBwRJIU+0muShctAUqaE4uQ8rf6lNSPqrY4mUOhsGi6O2Mlwys3vgTimh+9PjMeSTmKmtb0C8zbjixzbLE6WMVIzujgST0fXmRsThFxiRrUHuFiyVVRLgBn8K+A6QuUCS+WH3XovMN5WDOd4e3IC8jpnynp9d X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN6PR15MB1187;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1187; X-Forefront-PRVS: 00603B7EEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(24454002)(377424004)(189002)(199003)(377454003)(8676002)(105586002)(76176999)(93886004)(65806001)(68736007)(5001770100001)(65956001)(83506001)(66066001)(50986999)(305945005)(36756003)(65826007)(77096005)(4001350100001)(107886002)(117156001)(50466002)(47776003)(106356001)(5660300001)(54356999)(31696002)(7846002)(64126003)(2950100001)(92566002)(101416001)(23746002)(2906002)(189998001)(7736002)(33646002)(86362001)(81166006)(42186005)(31686004)(586003)(6116002)(230700001)(97736004)(2201001)(3846002)(81156014);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1187;H:[192.168.1.153];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1187;23:LyjtkR3QcwyZJJS5LWPWzEUwMLW+octmm2EQY?= =?Windows-1252?Q?PZeof4jBYidRVnJR3cXndhKE/PqAxB2CDXQ9skV61JUEbRqitBY01p8X?= =?Windows-1252?Q?ECiWre5/QeJ2pVuOVN4j4JcorR/svBk33FYZ9tEIbugm33qGoPv37ZKb?= =?Windows-1252?Q?M0lVPpyBO/7Jx1MRhl2GoJjF2XABWGXDfpBT+z/O/THZ1FzFDcesPru2?= =?Windows-1252?Q?FUkEMf5lnHo3c4cSkRIqASBsaZ+lFK8ftO3qSoLEIZpYOcCP2Oq72YgK?= =?Windows-1252?Q?6rkChADLXckRtW2tRq+xe9dtGP0L4+ICsBarPBJNLbLnXetpQb3bHWJB?= =?Windows-1252?Q?zT6pA0Y56OCUk9y7jjj0lMnZkpce0T53u9VRmSFqaicTooFW7YsfcpYz?= =?Windows-1252?Q?iHbj76ndITJ0FGAgkEEeNTodzZEoYVqQBwdICqpkqm4P5inTKpENpiKH?= =?Windows-1252?Q?FhYb0Wk0iRBYmk4BkbBHn2NpazqL53UCEFbHeKOSR5UpC0JJK3JRzAx/?= =?Windows-1252?Q?eozf8LjOes/Cqjz4IK/7FIagyoHwdk+RYwtudBcV2kTOYtX6R1utP+a3?= =?Windows-1252?Q?RhQjswd3ebhqgejr4VQ6OLr5+vhqUBvAXltzWdaHjzXuQesLRZdoDDQv?= =?Windows-1252?Q?+yS+J1dGJW6WRro3qX5bwTeZYhijq3zwDiFX7CR9SpvgMxmljoeiIJaz?= =?Windows-1252?Q?eACM4wXiGRhqev+YjhxWY6i5dXBTWP5+mv/FKcNLfoYAB8r15suP7Ttj?= =?Windows-1252?Q?M4UIu2qxNLyCVCnO1zpueDhX94wWWc4WXx3u4glNEvx7Hu8Lrpyvp115?= =?Windows-1252?Q?3qpsCUHl2C2vmg3PzFzcbCsZ2vUGPMXq3MyP2q4dfVKLxalSP041ko7z?= =?Windows-1252?Q?1jKQ8vEjNIwohVWgRnxrWr+IF7oYzYPHn/dCWi3foKDvGkIYrcAKoCdK?= =?Windows-1252?Q?O36Pg7t2XXbPpvocUDbGCrw5dS5FTuIPzUBHl7ACopJBxM+r7q0K5mRT?= =?Windows-1252?Q?j6OWf4bwLr+sdqgQLGNbgYuVcWRlJ5ZRY/XxRU4ftAwsnEmAMtFKrHCe?= =?Windows-1252?Q?N2UAY0jbv8RbaavIVSIdZI0VlG/i+kxTXQSpuUI3mP4jBGVccz5RBgBj?= =?Windows-1252?Q?fPxO5cpiOUTWd5U3lJ6lEX6+lCnWyKamA/EqLk2WbES+7L/0uoLuyKSH?= =?Windows-1252?Q?ARCWnnm8yFb2Oa+bWUiyOqRayKDouMIETzB+QGMwqZCm0jgWiIzx9sZE?= =?Windows-1252?Q?MvZXm/5Daqvr4eXXNYRVr8AiiiHGPTNKrbax0bth9ngueEpIJ02GQuTR?= =?Windows-1252?Q?evIUrdw/mIHvFR+k0Ciw4pTgZRnxybDmc4hBPg7EydWRatSX1150JoEL?= =?Windows-1252?Q?xQp4j2fTXx3OGQU5UE4OC1Z8saU/RVg0YC+xJyLPoXK69kYvppyOc3ad?= =?Windows-1252?Q?gIq7Mfui7jNdXnYyASz?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;6:bZrZiMuuoitz0Cpi2eZWhw2lZeZrBjWYYNbMOXE3rqY9+EefIcH65oOETO7UpqiHJpSYLCYgwMFCV19lHvk3kNXXYW6LM3jtdZS7RPRnjjM/ku2FIZHF2K05iiFGt4HhsGyhQdjFO/a7Uf85nCgqptxnckIWhaEb9uo6gbj+FNsy8vXQb7hCm/qZlrz7fQVsyMA7BvnJCm2SZUIFVl2LuPfQ/rfhDNLfbzyo7pdwFHv2hWhUDFTn3ewEy5KbUAt02Cvtju6XbqrRvDnffMBtUVSEM/+rdcFGwPmXHO1GbVo=;5:VxhbTATWEOqMXyPSa0f3lyp8kUiw2gI/aykWKog2vjsO1mAFFAgLE1hRudSR5TLLv8XLlSAETDbkznREx2RyAOxrD2IVe280QsYw0NrtRxwpTixNlL+tpkNhHLX3uZHLBcgwgp6gi4CNt98efqQS+A==;24:i8w8YFziKne7/6QQoRMuURn6S9+3jbC5/kd6iyG65jnW/R0iA7gqemC9TPLTi4bzQWfiQjz81upT+IDeeeUPpwHKp0oBgD4OAALJ88yekZE=;7:kkE+OgE4PF1nTRvvou/VMGXMCjI3JpWnKEbXFI6kopQ9GR8B/u2u+vUKkpDUs5hLP/5v6go5CSNbF0LAJE4zb2x2FG59lsiNMjy8FsVGM6lwrgqlmdQcFXfg77KqcnodGWY8K+iqXPrZdFVdYFTz0tpB4dvSH1re3RdX8n0W3bruWOcUuEG6zm1O7mqkgtfDHufKgF9ujaXNnS7aXhCiV6WcNN4YSpJANvVoCZO6r/XzOUkd2+ElbcevxfQEK7vt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1187;20:QBfOnGGD0RCoObQpViFfObtGrG5KH9oIRXcxVi6UZgYTlzCERZjJVvRY3EyIKP6VuC7AVs3ppMvCwe61FwiPDtYvl7bvG0DINA9tlbT9lbF9U1ujYWyb1DjTvw2LJ/d/OTqIR6OlreZpY/O87utuJMLLzsUvzHr2PktlpAzCxiE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2016 16:20:51.5105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1187 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-09_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2016 10:15 AM, Joe Perches wrote: > On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote: >> The variable is called 'runtime_flags' - if that doesn't already tell >> the reader how it's used, then I'd suggest the reader go read something >> else. >> >> I'm all for using established APIs where it makes sense. Declaring a >> bitmap for a few fields isn't that. > > Deviating from established APIs makes no sense. Look, doing set/test/clear bit on an unsigned long is a very well established API. We've been doing that _forever_. As I said in my original email, I have nothing against using bitmaps _where they make sense_. Manually allocating an array for X number of bits (where X > 32), yes, by all means use the bitmap helpers. This is my final reply on this topic. -- Jens Axboe