From: Kevin Cernekee <cernekee@gmail.com>
To: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] MIPS: Disable address swizzling on __raw MMIO operations
Date: Tue, 26 May 2009 16:57:34 -0700 [thread overview]
Message-ID: <26a78e954b7e1570179fba0c56aa129af1a247e0@localhost> (raw)
I have a big-endian MIPS32-based ASIC configured as follows:
CONFIG_SWAP_IO_SPACE is not set
mangle-port.h says:
#define __swizzle_addr_b(port) ((port) ^ 3)
#define __swizzle_addr_w(port) ((port) ^ 2)
#define __swizzle_addr_l(port) (port)
#define __swizzle_addr_q(port) (port)
(copied from mach-ip32/mangle-port.h)
The PCI drivers use {read,write}[bwl]. PCI byte and word (16-bit)
accesses are address-swizzled but not endian-swapped. Since 32-bit
accesses are the common case, this generates the most efficient code.
The MTD drivers (in my case, physmap) use __raw_{read,write}[bwl].
This is a problem because on MIPS, the __raw functions still enable
address swizzling.
I am submitting a patch to disable address swizzling for the __raw
operations.
There are currently three other MIPS platforms using address
swizzling:
txx9/jmr3927 only uses the swizzle facility to make the rtc-ds1742
driver work. This driver uses standard (non-__raw) readb()
operations, which will continue to function normally with my patch in
place.
sgi-ip27 swizzles 16-bit PCI word addresses but not byte addresses.
It only registers a single platform_device (rtc-m48t35) which has no
__raw operations.
sgi-ip32 swizzles both 16-bit and 8-bit PCI addresses. It registers
the following platform_device's:
8250 - uses standard read/write operations
meth - uses volatile struct accesses only
sgio2audio - uses readq/writeq
sgi_btns - uses readq/writeq
rtc_cmos - uses inb_p/outb_p
Based on this information, I do not believe that my change will have
an adverse impact on any other systems.
next reply other threads:[~2009-05-27 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 23:57 Kevin Cernekee [this message]
2009-05-26 23:59 ` [PATCH 1/1] " Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a78e954b7e1570179fba0c56aa129af1a247e0@localhost \
--to=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®