From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.171.202.116 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794988454; b=NQO4KNpL36c0gw3HA4OxRuvURrsAoL+ldvSrjoNSjsKSKuzQlCNSWn5KrdBAvHcDYNKl 8aqdfmucy0YCOSAt7nP3rrvfuzwrHYK+ctX6gBqP+g82FGGsMTsGg6BY2qvCTA5/hyAZF W1njIZ1ZSe0Vng5625m6ZkbRWgktUenikz3SMpkoVGrnasVrNdkUEj3R9RoV1gVtGHV9t mG5WoVGMIryHxSBIsNesljmkMjXw6RL9jVLbutrtjxnP5Pw++cs9pPugw5R3ra9Mw/CAd qIYWT0LsKA1lhaDHemThXckbLsW4X/zxUPIbJLW0rEyunlLdMa4DUZiG2dwpdH61+Nw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794988454; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:Organization:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=tb4WIW6lqZ5+Z3GQF5djG9Xnbu4tg/4H1vvuQxWHZEg=; b=fUFvO5HAao7h76ussZNhRh+z62Dlyh8DsuWVrVtl8RqHaBmHtdZtJtrX1mO35GJSf/hq +4AdJax+mZ8aMmjr9BNvyASdGRJs9LDK7PiaL+/GM6ouPHGY/KzIyfSU0oRDn+39UMnGz YQJIDh8rwC/B2skdJAZPL0pg0mHcJt7nWIio2vSyIUxhXuLh1nZeEYb/wtWyPiuycjHy+ S38Ymn8bsfqL4b5YeVxsy3Tmvzd2F2Lc1O2u56TduTicniOhKqVJAnIHAWAoq0JfUYbHc w4HYMAhSm7ZGM61OD1X8qAOd635dXwJVmj7pE/X5oynxdY9bDRnB/piTJsSCj8MdgRw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=ehFSdTb7; arc=none smtp.remote-ip=185.171.202.116 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 835FB606A880; Wed, 18 Nov 2026 07:54:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 835FB606A880 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=ehFSdTb7 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 938EEC4CBD8; Wed, 18 Nov 2026 07:54:16 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B37195FE9B; Wed, 18 Nov 2026 07:54:11 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 433CB11BC05A5; Wed, 18 Nov 2026 08:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1794988450; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=tb4WIW6lqZ5+Z3GQF5djG9Xnbu4tg/4H1vvuQxWHZEg=; b=ehFSdTb7uzrE6rWYmg35Q80WHEhS+LYoh5/jgxjMBUtq3YOPIPQRNGsHszTdpZDhC0eM+h +Z3t9bGej6AxdCqgXoUS40XFXxMHaFCkeB5XmXEtEBOfc8UIa4zUko7flR9Yj2eRi2ARIl zmRXEpcBIlSf3oPeCV1DeD9lc+W+zOztiZJFW4hGoTy5pixgPuCVFuqH4mg9euuq4OMoOR c3YH3rjGHsxXELQXYqWaG/m0ycwKUr6t8xa2wkIde2j+85OG04m696IEyDZ3LZ7kLRsAV5 EPKg1J4Vp4wedu0QFepN1tbPB+blaLolM0E2FQTvOZRk6tvDmSCRossHxazw8w== Message-ID: <26aa0b74-e3f8-4405-ab87-743f5f8ef197@bootlin.com> Date: Wed, 18 Nov 2026 08:54:05 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/13] arm64: add Synaptics SL2610 SoCs and RDK boards To: Jisheng Zhang , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Mark Rutland , Sebastian Hesselbarth , Stephen Boyd , Brian Masney , Jerome Brunet , Linus Walleij , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org References: <20261115102401.3520-1-jszhang@kernel.org> From: Richard GENOUD Content-Language: en-US, fr Organization: Bootlin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Le 16/11/2026 à 13:06, Jisheng Zhang a écrit : > On Sun, Nov 15, 2026 at 06:23:39PM +0800, Jisheng Zhang wrote: >> Add initial support for the Synaptics SL261X SoCs and corresponding >> RDK boards. >> >> The SL261X SoCs include five pin-to-pin compatible SoCs: SL2611, SL2613, >> SL2615, SL2617, and SL2619. >> >> Only reset, pinctrl, clk/pll, uart, gpio, i2c, spi, i3c are included in >> this series. The support for Ethernet, USB, SDHCI, CAN, DMAC, XSPI will >> be submitted after this series is merged. >> >> since v1: >> - rebase on latest rcN >> - drop some patches which have been merged >> - let the "gbl" node export pinctrl/reset/clk devices with >> MFD_CELL_NAME() >> - use instead of >> - adopt some coding suggestions from Uwe >> - Use 0 and 1 to select normal and strong pull-up on 10-bit pads > > Other SoCs doesn't use this defintion for pull up or strong pull up. > After consulting our HW people, the strong pull up isn't used at > all, so I will remove strong pull up support in newer version. We can > add back its support when it's really needed in the future, nothing > breaks. I've found a similar definition here: https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml#L73-L78 But also a plain new property here: https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/starfive,jh7100-pinctrl.yaml#L153-L155 And another with the real strong pull-up value: https://elixir.bootlin.com/linux/v7.3.1/source/Documentation/devicetree/bindings/pinctrl/thead,th1520-pinctrl.yaml#L94-L99 As you said, if it's not used, we can skip it and add a property in the future (or the real value if we have it). But we won't be able to use 1 for strong and 0 for normal. Regards, Richard > >> - collect Acked-by tag >> >> Jisheng Zhang (13): >> arm64: kconfig: let ARCH_BERLIN cover Synaptics arm64 SoCs >> pinctrl: berlin: use u16 instead of u8 for the offset >> pinctrl: berlin: enable module build support >> pinctrl: berlin: add optional pinconf support >> dt-bindings: soc: synaptics: add SL2610 system controllers >> soc: synaptics: add SL2610 system controller support >> reset: add Synaptics SL2610 reset controller support >> pinctrl: berlin: add Synaptics SL2610 pin controller support >> clk: berlin: add Synaptics clock controller helpers >> clk: berlin: add Synaptics SL2610 clocks and PLLs >> dt-bindings: arm: berlin: add Synaptics SL2610 SoCs and RDK boards >> arm64: dts: synaptics: add SL2610 family SoCs >> arm64: dts: synaptics: add SL2610 family RDK boards >> >> .../bindings/arm/marvell,berlin.yaml | 20 + >> .../soc/synaptics/syna,sl2610-soc-syscon.yaml | 178 ++++ >> MAINTAINERS | 8 + >> arch/arm64/Kconfig.platforms | 4 +- >> arch/arm64/boot/dts/synaptics/Makefile | 5 + >> arch/arm64/boot/dts/synaptics/sl2611-rdk.dts | 16 + >> arch/arm64/boot/dts/synaptics/sl2611.dtsi | 457 +++++++++++ >> arch/arm64/boot/dts/synaptics/sl2613-rdk.dts | 16 + >> arch/arm64/boot/dts/synaptics/sl2613.dtsi | 12 + >> arch/arm64/boot/dts/synaptics/sl2615-rdk.dts | 16 + >> arch/arm64/boot/dts/synaptics/sl2615.dtsi | 46 ++ >> arch/arm64/boot/dts/synaptics/sl2617-rdk.dts | 16 + >> arch/arm64/boot/dts/synaptics/sl2617.dtsi | 46 ++ >> arch/arm64/boot/dts/synaptics/sl2619-rdk.dts | 16 + >> arch/arm64/boot/dts/synaptics/sl2619.dtsi | 44 + >> .../boot/dts/synaptics/sl261x-rdk-common.dtsi | 135 ++++ >> drivers/clk/Kconfig | 1 + >> drivers/clk/berlin/Kconfig | 34 + >> drivers/clk/berlin/Makefile | 4 + >> drivers/clk/berlin/clk-sl2610.c | 360 +++++++++ >> drivers/clk/berlin/sl-clk.c | 279 +++++++ >> drivers/clk/berlin/sl-clk.h | 31 + >> drivers/clk/berlin/sl-sysmgr-clk.c | 241 ++++++ >> drivers/clk/berlin/sl-sysmgr-clk.h | 44 + >> drivers/clk/berlin/sl2610-pll.c | 145 ++++ >> drivers/clk/berlin/sl2610-pll.h | 14 + >> drivers/pinctrl/berlin/Kconfig | 16 + >> drivers/pinctrl/berlin/Makefile | 1 + >> drivers/pinctrl/berlin/berlin.c | 259 +++++- >> drivers/pinctrl/berlin/berlin.h | 17 +- >> drivers/pinctrl/berlin/pinctrl-sl2610.c | 759 ++++++++++++++++++ >> drivers/reset/Kconfig | 13 + >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-sl2610.c | 224 ++++++ >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/synaptics/Kconfig | 14 + >> drivers/soc/synaptics/Makefile | 2 + >> drivers/soc/synaptics/sl2610-syscon.c | 84 ++ >> include/dt-bindings/clock/syna,sl2610.h | 131 +++ >> include/dt-bindings/reset/syna,sl2610-reset.h | 80 ++ >> 41 files changed, 3771 insertions(+), 20 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/soc/synaptics/syna,sl2610-soc-syscon.yaml >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2611-rdk.dts >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2611.dtsi >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2613-rdk.dts >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2613.dtsi >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2615-rdk.dts >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2615.dtsi >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2617-rdk.dts >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2617.dtsi >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2619-rdk.dts >> create mode 100644 arch/arm64/boot/dts/synaptics/sl2619.dtsi >> create mode 100644 arch/arm64/boot/dts/synaptics/sl261x-rdk-common.dtsi >> create mode 100644 drivers/clk/berlin/Kconfig >> create mode 100644 drivers/clk/berlin/clk-sl2610.c >> create mode 100644 drivers/clk/berlin/sl-clk.c >> create mode 100644 drivers/clk/berlin/sl-clk.h >> create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.c >> create mode 100644 drivers/clk/berlin/sl-sysmgr-clk.h >> create mode 100644 drivers/clk/berlin/sl2610-pll.c >> create mode 100644 drivers/clk/berlin/sl2610-pll.h >> create mode 100644 drivers/pinctrl/berlin/pinctrl-sl2610.c >> create mode 100644 drivers/reset/reset-sl2610.c >> create mode 100644 drivers/soc/synaptics/Kconfig >> create mode 100644 drivers/soc/synaptics/Makefile >> create mode 100644 drivers/soc/synaptics/sl2610-syscon.c >> create mode 100644 include/dt-bindings/clock/syna,sl2610.h >> create mode 100644 include/dt-bindings/reset/syna,sl2610-reset.h >> >> -- >> 2.55.0 >> >> > -- Richard Genoud, Bootlin Embedded Linux and Kernel engineering https://bootlin.com