From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750830AbdE1MZh (ORCPT <rfc822;w@1wt.eu>);
        Sun, 28 May 2017 08:25:37 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33476 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750773AbdE1MZg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 28 May 2017 08:25:36 -0400
Subject: Re: [PATCH] regulator: bd9571mwv: Statize local symbols
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
References: <20170528060217.21485-1-axel.lin@ingics.com>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
From: Marek Vasut <marek.vasut@gmail.com>
Message-ID: <26c45bf7-7c83-1e2a-220f-8d2dcf1318fa@gmail.com>
Date: Sun, 28 May 2017 14:20:25 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170528060217.21485-1-axel.lin@ingics.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/28/2017 08:02 AM, Axel Lin wrote:
> These functions are only used by this driver, make them static.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Obviously correct,
Acked-by: Marek Vasut <marek.vasut@gmail.com>

> ---
>  drivers/regulator/bd9571mwv-regulator.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
> index 8ba206f..c67a83d 100644
> --- a/drivers/regulator/bd9571mwv-regulator.c
> +++ b/drivers/regulator/bd9571mwv-regulator.c
> @@ -43,7 +43,7 @@ enum bd9571mwv_regulators { VD09, VD18, VD25, VD33, DVFS };
>  		.linear_min_sel		= _lmin,		\
>  	}
>  
> -int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
> +static int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
>  {
>  	unsigned int val;
>  	int ret;
> @@ -55,8 +55,8 @@ int bd9571mwv_avs_get_moni_state(struct regulator_dev *rdev)
>  	return val & BD9571MWV_AVS_SET_MONI_MASK;
>  }
>  
> -int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> -					 unsigned int sel)
> +static int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
> +						unsigned int sel)
>  {
>  	int ret;
>  
> @@ -68,7 +68,7 @@ int bd9571mwv_avs_set_voltage_sel_regmap(struct regulator_dev *rdev,
>  				 rdev->desc->vsel_mask, sel);
>  }
>  
> -int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
> +static int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
>  {
>  	unsigned int val;
>  	int ret;
> @@ -87,8 +87,8 @@ int bd9571mwv_avs_get_voltage_sel_regmap(struct regulator_dev *rdev)
>  	return val;
>  }
>  
> -int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
> -					 unsigned int sel)
> +static int bd9571mwv_reg_set_voltage_sel_regmap(struct regulator_dev *rdev,
> +						unsigned int sel)
>  {
>  	return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
>  				 rdev->desc->vsel_mask, sel);
> 


-- 
Best regards,
Marek Vasut