From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6589C2D0A3 for ; Fri, 6 Nov 2020 11:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5504B2072E for ; Fri, 6 Nov 2020 11:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uj+6QUxN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbgKFLAu (ORCPT ); Fri, 6 Nov 2020 06:00:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45583 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgKFLAu (ORCPT ); Fri, 6 Nov 2020 06:00:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604660448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZtZT7itrVpNRfBlr3Cazy0HWs7zXJS+GGQb2VbmhUxk=; b=Uj+6QUxNBm0P0iXvq7onhHJrK8+OfAG/0pFmW20p+x/CI63ArQ+Gde/FZe/pkQMA66MqDY MH/AusmohfLYvG4Hm9Qx74GF8pzt7ikcIIlF6rXbeOUolB1oRgq1rrE34vPwsXFS0H94k8 YwrtoSugQcFfGftH8oW/Qr/5KmW+kmY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-V632puqaPOOAtjHWuSLJLg-1; Fri, 06 Nov 2020 06:00:47 -0500 X-MC-Unique: V632puqaPOOAtjHWuSLJLg-1 Received: by mail-wm1-f71.google.com with SMTP id l16so294088wmh.1 for ; Fri, 06 Nov 2020 03:00:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZtZT7itrVpNRfBlr3Cazy0HWs7zXJS+GGQb2VbmhUxk=; b=bwP4mTRjiz4sLIAUruUGPcsLRUgesvbSF+w+l8fRkObbLFEAIRGXxOykvqQMUwnfPX kuRbCkxMBhLQdm+XfY9OSKwmcH3YvKa/h7qp97CCPpSGyvAHqz25ScZDSAv0nOTmiwIT xP6IJo4/3ttXtIy/ak24lnxcJ9WgiPwp9K8sd3sPI0wp7NU3ZeqNjJyPcBSCIal/8yBS Sd/6xj3itEIbpcmEOvLD4mDJaXB0LcP7kz6nPQfA4hmyWiHvrtjsDdZOs2qQQlviIzPz 0B3HNgy1OCDauIHeTWR3XeY20HT5GxKlSr/vNK75vNlwx1BcG1H2YBn11HALjnxsQOjg qoVg== X-Gm-Message-State: AOAM533myAKAPFOeCBgJ+kmXtCm62iff5f4FcwyYCk7s2R6D1CGbDpa0 99wfNqJfI77yU0eSswiFqzPC9Vk1Kjwskeo1/RXzdnXerMGXTBH43OwR41rElXRzNyhPZptP1QE pvmLhAmH37YMmNZKHHcsH6j7U X-Received: by 2002:a1c:b041:: with SMTP id z62mr1861616wme.183.1604660443119; Fri, 06 Nov 2020 03:00:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJy998yT/dbdVsyfPvdRyx12Gso3/GpsD6DmKxXxQdpz/rRJ9mO5IMFzBixjrV3UiX4aJV0qjg== X-Received: by 2002:a1c:b041:: with SMTP id z62mr1861590wme.183.1604660442885; Fri, 06 Nov 2020 03:00:42 -0800 (PST) Received: from [192.168.10.118] ([93.56.170.5]) by smtp.gmail.com with ESMTPSA id l3sm1969557wmf.0.2020.11.06.03.00.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2020 03:00:42 -0800 (PST) Subject: Re: [PATCH v13 06/14] KVM: Make dirty ring exclusive to dirty bitmap log To: Peter Xu , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sean Christopherson , "Dr . David Alan Gilbert" , Andrew Jones References: <20201001012044.5151-1-peterx@redhat.com> <20201001012224.5818-1-peterx@redhat.com> From: Paolo Bonzini Message-ID: <26c461bc-b2e3-bc23-fff6-0377b09d325a@redhat.com> Date: Fri, 6 Nov 2020 12:00:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201001012224.5818-1-peterx@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/20 03:22, Peter Xu wrote: > > + /* Dirty ring tracking is exclusive to dirty log tracking */ > + if (kvm->dirty_ring_size) > + return -EINVAL; > + ENXIO is slightly more appropriate (especially for debugging, as EINVAL suggests that the arguments were wrong and not some external state). Paolo