From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49208.qiye.163.com (mail-m49208.qiye.163.com [45.254.49.208]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA76B1C3C05; Wed, 22 Jan 2025 09:05:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.208 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737536750; cv=none; b=qQWTyznVWK2Xba3Cvud0WSEaMiOSOgNjBxum6/w7MgmT9HDhcCFSsKPW96xtw0cZZ8z6XbCP1s+t0aQ9uUuFWh2YU22j/JHKLGOJgeRAZ/ccYCCDDcGVNj02tkKcrdmjVmEz4QVtNQyK6PSbgsqs4YWWm0Q1GWqeXgOabLNFD2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737536750; c=relaxed/simple; bh=w32XRroxEs/OX5FEdQuTpvnLoa6rOxeKNMfKKVSsWao=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LAcOxiwG7UwMNUNRE2n1bkGYPaTs4PbevutG2mOCImcEdhjPucgxR/ExlPY4ENNrrPaWSiR9GMnPLMT7Wg757G+cSYyawWpXuhk0wp5xx++3jUWhTVHYqlALxJFBOu93QSpv+E/gACC+FSMY6zc5fm+xQ63T0wpfOCpHNcd8aS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=CG+gEnx+; arc=none smtp.client-ip=45.254.49.208 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="CG+gEnx+" Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 96647672; Wed, 22 Jan 2025 17:05:37 +0800 (GMT+08:00) Message-ID: <26c55255-2671-4bb1-aaee-c3145f8698f7@rock-chips.com> Date: Wed, 22 Jan 2025 17:05:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 20/20] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board To: Andy Yan Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, rfoss@kernel.org, vkoul@kernel.org, sebastian.reichel@collabora.com, cristian.ciocaltea@collabora.com, l.stach@pengutronix.de, dmitry.baryshkov@linaro.org, andy.yan@rock-chips.com, hjc@rock-chips.com, algea.cao@rock-chips.com, kever.yang@rock-chips.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20250109032725.1102465-1-damon.ding@rock-chips.com> <20250109032725.1102465-21-damon.ding@rock-chips.com> <8927876.291e.19454e86e8f.Coremail.andyshrk@163.com> Content-Language: en-US From: Damon Ding In-Reply-To: <8927876.291e.19454e86e8f.Coremail.andyshrk@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGkIdHlZMTx4eGRlIGh9LTUxWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCSE NVSktLVUpCS0tZBg++ X-HM-Tid: 0a948d42906703a3kunm96647672 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NxQ6Iio4STIXEi9IPh5LDBYV KTAaCQ5VSlVKTEhMTkhNTEhCSkpLVTMWGhIXVR8aFhQVVR8SFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFISkxMNwY+ DKIM-Signature:a=rsa-sha256; b=CG+gEnx+XPdVro1zdFzCtUaeVySUsXtaffUl3mFF+lfs47HUrqfKK/fVH37Afw5wPC0Kqr4qZ/Iy2hmAuSnfp6ix+7g6MKIZ7LKrZ7eR1gKfBCu5oy7Kgp7rXs1q97nz1ATOSJb8cQyspPDbsna3Iaagk6FtyLDygDm6807jCQw=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=hsQBhgtpgyLUVlhj2uOdXGpB5uzrnxpQS3g2lRTQAn8=; h=date:mime-version:subject:message-id:from; Hi Andy, On 2025/1/11 18:28, Andy Yan wrote: > > Hi Damon, > > At 2025-01-09 11:27:25, "Damon Ding" wrote: >> Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: >> - Set pinctrl of pwm12 for backlight >> - Enable edp0/hdptxphy0/vp2 >> - Add aux-bus/panel nodes >> >> Signed-off-by: Damon Ding >> >> --- >> >> Changes in v2: >> - Remove brightness-levels and default-brightness-level properties in >> backlight node. >> - Add the detail DT changes to commit message. >> >> Changes in v3: >> - Use aux-bus instead of platform bus for edp-panel. >> >> Changes in v4: >> - Add comments related to the use of panel compatible "lg,lp079qx1-sp0v" >> in the commit message. >> >> Changes in v5: >> - Use "edp-panel" instead of "lg,lp079qx1-sp0v" >> - Remove unnecessary comments in commit message >> - Assign the parent of DCLK_VOP2_SRC to PLL_V0PLL >> --- >> .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 54 +++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> index bc4077575beb..a8c151b41e21 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> @@ -9,6 +9,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include "rk3588s.dtsi" >> >> @@ -238,6 +239,41 @@ &combphy2_psu { >> status = "okay"; >> }; >> >> +&edp0 { >> + force-hpd; >> + status = "okay"; >> + >> + aux-bus { >> + panel { >> + compatible = "edp-panel"; >> + backlight = <&backlight>; >> + power-supply = <&vcc3v3_lcd_edp>; >> + >> + port { >> + panel_in_edp: endpoint { >> + remote-endpoint = <&edp_out_panel>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&edp0_in { >> + edp0_in_vp2: endpoint { >> + remote-endpoint = <&vp2_out_edp0>; >> + }; >> +}; >> + >> +&edp0_out { >> + edp_out_panel: endpoint { >> + remote-endpoint = <&panel_in_edp>; >> + }; >> +}; >> + >> +&hdptxphy0 { >> + status = "okay"; >> +}; >> + >> &i2c3 { >> status = "okay"; >> >> @@ -399,6 +435,7 @@ usbc0_int: usbc0-int { >> }; >> >> &pwm12 { >> + pinctrl-0 = <&pwm12m1_pins>; >> status = "okay"; >> }; >> >> @@ -1168,3 +1205,20 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 { >> }; >> }; >> }; >> + >> +&vop_mmu { >> + status = "okay"; >> +}; >> + >> +&vop { >> + assigned-clocks = <&cru DCLK_VOP2_SRC>; >> + assigned-clock-parents = <&cru PLL_V0PLL>; > > It's necessary to explain why we need to assign V0PLL for DCLK_VOP2_SRC in commit message. > > I will add relevant explainations in next version. >> + status = "okay"; >> +}; >> + >> +&vp2 { >> + vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 { >> + reg = ; >> + remote-endpoint = <&edp0_in_vp2>; >> + }; >> +}; >> -- >> 2.34.1 >> Best regards, Damon