From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: <linux-kernel@vger.kernel.org>,
Michal Simek <michal.simek@xilinx.com>, <monstr@monstr.eu>,
John Linn <john.linn@xilinx.com>
Cc: <git@xilinx.com>, <josh.cartwright@ni.com>,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH 2/7] arm: zynq: timer: Remove unnecessary register write
Date: Tue, 18 Dec 2012 16:16:34 -0800 [thread overview]
Message-ID: <26c7059f-09d2-4b0a-83a8-e27d10fbd100@DB3EHSMHS008.ehs.local> (raw)
In-Reply-To: <1355876199-23788-1-git-send-email-soren.brinkmann@xilinx.com>
Acknowedging an interrupt requires to read the interrupt register
only. The write was only required to work around a bug in
the QEMU implementation of the TTC, which is fixed.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
Acked-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
@Peter: I took over your ACK, since it's the same change we applied to the
Xilinx tree a couple of weeks ago. Let me know if this should be removed.
arch/arm/mach-zynq/timer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-zynq/timer.c b/arch/arm/mach-zynq/timer.c
index 570491d..f1d224b 100644
--- a/arch/arm/mach-zynq/timer.c
+++ b/arch/arm/mach-zynq/timer.c
@@ -121,8 +121,7 @@ static irqreturn_t xttcps_clock_event_interrupt(int irq, void *dev_id)
struct xttcps_timer *timer = &xttce->xttc;
/* Acknowledge the interrupt and call event handler */
- __raw_writel(__raw_readl(timer->base_addr + XTTCPS_ISR_OFFSET),
- timer->base_addr + XTTCPS_ISR_OFFSET);
+ __raw_readl(timer->base_addr + XTTCPS_ISR_OFFSET);
xttce->ce.event_handler(&xttce->ce);
--
1.8.0.2
next prev parent reply other threads:[~2012-12-19 0:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1355876199-23788-1-git-send-email-soren.brinkmann@xilinx.com>
2012-12-19 0:16 ` [PATCH 1/7] arm: zynq: timer: Replace PSS through PS Soren Brinkmann
2012-12-19 2:31 ` Josh Cartwright
2012-12-19 4:21 ` Soren Brinkmann
2012-12-19 0:16 ` Soren Brinkmann [this message]
2012-12-19 0:16 ` [PATCH 3/7] arm: zynq: timer: Remove unused #defines Soren Brinkmann
2012-12-19 0:16 ` [PATCH 4/7] arm: zynq: timer: Align columns Soren Brinkmann
2012-12-19 0:16 ` [PATCH 5/7] arm: zynq: timer: Remove redundant #includes Soren Brinkmann
2012-12-19 0:16 ` [PATCH 6/7] arm: zynq: timer: Fix comment style Soren Brinkmann
2012-12-19 0:16 ` [PATCH 7/7] arm: zynq: timer: Set clock_event cpumask Soren Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26c7059f-09d2-4b0a-83a8-e27d10fbd100@DB3EHSMHS008.ehs.local \
--to=soren.brinkmann@xilinx.com \
--cc=git@xilinx.com \
--cc=john.linn@xilinx.com \
--cc=josh.cartwright@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®