From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbcKRKiW (ORCPT ); Fri, 18 Nov 2016 05:38:22 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:44381 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbcKRKiR (ORCPT ); Fri, 18 Nov 2016 05:38:17 -0500 X-AuditID: cbfec7f2-f79556d000002c42-a1-582eda14be65 Subject: Re: [PATCH] arm64: dts: exynos: add the mshc_2 node for supporting T-Flash To: Jaehoon Chung , linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kgene@kernel.org, krzk@kernel.org, cw00.choi@samsung.com, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com From: Marek Szyprowski Message-id: <26cc8cc3-0a91-e253-5a10-8e080c3e486f@samsung.com> Date: Fri, 18 Nov 2016 11:38:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-version: 1.0 In-reply-to: <20161118071224.12876-1-jh80.chung@samsung.com> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsWy7djPc7oit/QiDKbOVbZ4v6yH0eL6l+es FvOPnGO1uPGrjdWi//FrZovz5zewW1zeNYfNYsb5fUwWS69fZLJo3XuE3eLlxxMsDtwea+at YfTYtKqTzaNvyypGj8+b5AJYorhsUlJzMstSi/TtErgyJuzYxlrwh6dizZPTzA2Ms7m6GDk5 JARMJJZce8QCYYtJXLi3nq2LkYtDSGApo0RD5wUo5zOjRPf8f+wwHRMOdzNCJJYxShw8+ZYV wnnOKHHq0UWwWcICoRJXV61hA7FFBPwlVk2dCFbELHCFUeLKy0+MIAk2AUOJrrddYEW8AnYS S7e8AWrm4GARUJXYO80CJCwqECNxe8o1ZogSQYkfk++BzecUsJE4MeUCE4jNLGAl8exfKyuE LS+xec1bZpBdEgKH2CVmt69lBpkpISArsekAM8QHLhIrT22A+llY4tXxLVCfyUh0dhxkgrD7 GSWaWrUh7BmMEufe8kLY1hKHj1+E2sUnMWnbdKjxvBIdbUIQJR4Siw82sEKEHSUmfpUGCQuB TLxwOW4Co/wsJM/MQvLALCQPLGBkXsUoklpanJueWmysV5yYW1yal66XnJ+7iRGYak7/O/5p B+PXE1aHGAU4GJV4eBec0o0QYk0sK67MPcQowcGsJMIbdUUvQog3JbGyKrUoP76oNCe1+BCj NAeLkjjvngVXwoUE0hNLUrNTUwtSi2CyTBycUg2MVsuXaSpOOX1CVMPipuQDJrbpcQ9zv/O7 bT60pq5NVtM5Qsf5VJBsmk1HU1TM3RcLth5WbTKUSzT8cH+79Tc2zUCrya81jX8u5vls4eOr 9TPfUXv7JgsT5Rf/C8qjTjvkPb+pMMtg1mex7Z8nfrqaFbdGl/tDSsF/G2nLyCd62eyTDXa3 fglTYinOSDTUYi4qTgQAi/dlVzEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t/xK7rSt/QiDC7+l7N4v6yH0eL6l+es FvOPnGO1uPGrjdWi//FrZovz5zewW1zeNYfNYsb5fUwWS69fZLJo3XuE3eLlxxMsDtwea+at YfTYtKqTzaNvyypGj8+b5AJYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9 Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWMWHHNtaCPzwVa56cZm5gnM3VxcjJISFgIjHhcDcj hC0mceHeerYuRi4OIYEljBJfTm9nh3CeM0qsWv+dHaRKWCBU4uqqNWwgtoiAr0Rb0ysmiKKJ jBKLfi5hBHGYBS4xSmybvZ4JpIpNwFCi620XWAevgJ3E0i1vWLoYOThYBFQl9k6zAAmLCsRI XH/2CKpEUOLH5HssIDangI3EiSkXwMYwC5hJfHl5mBXClpfYvOYt8wRGgVlIWmYhKZuFpGwB I/MqRpHU0uLc9NxiQ73ixNzi0rx0veT83E2MwOjbduzn5h2MlzYGH2IU4GBU4uFdcEo3Qog1 say4MvcQowQHs5IIb9QVvQgh3pTEyqrUovz4otKc1OJDjKZAP0xklhJNzgcmhrySeEMTQ3NL QyNjCwtzIyMlcd6SD1fChQTSE0tSs1NTC1KLYPqYODilGhh9P5f9DCxziFw874iJ8bV9688e unnofddsxivqCzbO2F1y2bov2d6qcebKD9J/3KMYV52+9CVKXvNTw5znYUm3nq7c9ePBj/9K EvyV91yEyxcvOHlkySyrs2/vfZ2+N0zKeBHv+0XJhjN2n/q8Wsv02clfmQb+qboB/uJl5X/8 fIUXTX/3noHtjRJLcUaioRZzUXEiAOD1KVLUAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161118103812eucas1p288558c9938c80aab745984e18be4dfbb X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161118071238epcas4p222702d2c716bf2d7cd9c9354ab99a189 X-RootMTR: 20161118071238epcas4p222702d2c716bf2d7cd9c9354ab99a189 References: <20161118071224.12876-1-jh80.chung@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Jaehoon, On 2016-11-18 08:12, Jaehoon Chung wrote: > Add the mshc_2 node for supporting T-flash. > > And it needs to add the "mshc*" aliases. Because dwmmc driver should be > assigned to "ctrl_id" after parsing to "mshc". > If there is no aliases for mshc, then it might be set to the wrong > capabilities. > > Signed-off-by: Jaehoon Chung > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 9ea3f32..75dab01 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -42,6 +42,8 @@ > spi2 = &spi_2; > spi3 = &spi_3; > spi4 = &spi_4; > + mshc0 = &mshc_0; > + mshc2 = &mshc_2; > }; > > chosen { > @@ -661,6 +663,23 @@ > assigned-clock-rates = <800000000>; > }; > > +&mshc_2 { > + status = "okay"; > + num-slots = <1>; > + cap-sd-highspeed; > + disable-wp; > + cd-gpios = <&gpa2 4 0>; cd-gpios = <&gpa2 4 GPIO_ACTIVE_HIGH>; > + cd-inverted; > + card-detect-delay = <200>; > + samsung,dw-mshc-ciu-div = <3>; > + samsung,dw-mshc-sdr-timing = <0 4>; > + samsung,dw-mshc-ddr-timing = <0 2>; > + fifo-depth = <0x80>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus1 &sd2_bus4>; > + bus-width = <4>; > +}; > + > &pinctrl_alive { > pinctrl-names = "default"; > pinctrl-0 = <&initial_alive>; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland