From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7908AC31E5B for ; Tue, 18 Jun 2019 18:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B8632080A for ; Tue, 18 Jun 2019 18:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730336AbfFRSXZ (ORCPT ); Tue, 18 Jun 2019 14:23:25 -0400 Received: from smtprelay0153.hostedemail.com ([216.40.44.153]:42518 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730200AbfFRSXW (ORCPT ); Tue, 18 Jun 2019 14:23:22 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 6E24F18020016; Tue, 18 Jun 2019 18:23:20 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: soda34_1c6b15c9e8444 X-Filterd-Recvd-Size: 3982 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Tue, 18 Jun 2019 18:23:15 +0000 (UTC) Message-ID: <26cd63896d6930385b4f770e305f0782a455a688.camel@perches.com> Subject: Re: [PATCH v2 1/4] staging: media: tegra-vde: Remove BIT() macro from UAPI header From: Joe Perches To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Maxime Coquelin , Alexandre Torgue , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Mark Rutland , Lorenzo Pieralisi , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend Date: Tue, 18 Jun 2019 11:23:13 -0700 In-Reply-To: <20190618161458.20499-5-digetx@gmail.com> References: <20190618161458.20499-1-digetx@gmail.com> <20190618161458.20499-5-digetx@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-06-18 at 19:14 +0300, Dmitry Osipenko wrote: > The BIT macro isn't available in userspace. Checkpatch complains about > shifts being used instead of the macro and people are starting to send > patches without realizing that it's a UAPI header file. Hence let's > replace the BIT macro with a hex values to make everyone happy. > > Signed-off-by: Dmitry Osipenko > --- > drivers/staging/media/tegra-vde/uapi.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/tegra-vde/uapi.h b/drivers/staging/media/tegra-vde/uapi.h > index a0dad1ed94ef..dd3e4a8c9f7e 100644 > --- a/drivers/staging/media/tegra-vde/uapi.h > +++ b/drivers/staging/media/tegra-vde/uapi.h > @@ -6,8 +6,8 @@ > #include > #include > > -#define FLAG_B_FRAME BIT(0) > -#define FLAG_REFERENCE BIT(1) > +#define FLAG_B_FRAME 0x1 > +#define FLAG_REFERENCE 0x2 > > struct tegra_vde_h264_frame { > __s32 y_fd; The BIT macro is already used quite a bit in uapi headers. I imagine all those need fixup... $ git grep -P '\bBIT\s*\(' include/uapi include/uapi/linux/bpf.h:#define BPF_FIB_LOOKUP_DIRECT BIT(0) include/uapi/linux/bpf.h:#define BPF_FIB_LOOKUP_OUTPUT BIT(1) include/uapi/linux/coresight-stm.h:#define STM_FLAG_TIMESTAMPED BIT(3) include/uapi/linux/coresight-stm.h:#define STM_FLAG_GUARANTEED BIT(7) include/uapi/linux/nl80211.h: * bitmask of BIT(NL80211_BAND_*) as described in %enum include/uapi/linux/pkt_sched.h:#define TC_ETF_DEADLINE_MODE_ON BIT(0) include/uapi/linux/pkt_sched.h:#define TC_ETF_OFFLOAD_ON BIT(1) include/uapi/linux/psci.h:#define PSCI_1_0_OS_INITIATED BIT(0) include/uapi/linux/serio.h:#define SERIO_TIMEOUT BIT(0) include/uapi/linux/serio.h:#define SERIO_PARITY BIT(1) include/uapi/linux/serio.h:#define SERIO_FRAME BIT(2) include/uapi/linux/serio.h:#define SERIO_OOB_DATA BIT(3) include/uapi/linux/tc_act/tc_ctinfo.h: CTINFO_MODE_DSCP = BIT(0), include/uapi/linux/tc_act/tc_ctinfo.h: CTINFO_MODE_CPMARK = BIT(1)