Re: [PATCH v2] platform/x86: Add WMI driver for Redmibook keyboard.

[Gladyshev Ilya <foxido@foxido.dev>]

Thx for review

On 7/30/25 19:33, Armin Wolf wrote:
>> +
>> +    if (obj->type != ACPI_TYPE_BUFFER) {
>> +        dev_err(&wdev->dev, "Bad response type %u\n", obj->type);
>> +        return;
>> +    }
>> +
>> +    if (obj->buffer.length != 32) {
> 
> Please also accept oversized buffers.
>
Sorry if this is a stupid question, but isn't any size other than 32 a 
sign of a firmware bug?

>> +
>> +    /* AI key quirk */
>> +    if (entry->keycode == KEY_ASSISTANT) {
>> +        value = !(payload & AI_KEY_VALUE_MASK);
> 
> I would rather check the payload for 0x00011901 here.
Personally I prefer to think about it as "some value encoded in payload" 
rather than "is it AI button release payload?", because in the latter 
case alternatives are more unclear. It's just a preference, btw, would 
fix if you insist.

--
Gladyshev Ilya