From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@nxp.com>,
linux-usb@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Subject: Re: [PATCH] usb: chipidea: Fix ULPI on imx51
Date: Thu, 21 Jun 2018 17:25:01 +0300 [thread overview]
Message-ID: <26d9fd57-07bc-0bba-2f29-ca778bd85328@cogentembedded.com> (raw)
In-Reply-To: <0f31d801-528e-54ee-f385-b7aa3eef414f@cogentembedded.com>
21.06.2018 17:12, Nikita Yushchenko wrote:
>>>> This patches causes a regression on a imx51-babbage running 4.18-rc1:
>>>> I get a kernel hang.
>>>>
>>>> If I revert it on top of 4.18-rc1, then it boots fine and USB host is
>>>> functional.
>>>>
>>>> I understand this patch fixes a kernel hang for you, so which commit
>>>> is responsible for the hang you observe?
>>>>
>>
>> I never assumed it was a regression and that USB worked on RDU1 board
>> before, so I never tried to see if this was a regression. I can only
>> tell you that it hangs as soon as any PORTSC registers are accessed.
>
> Hang at register access usually means that module that owns the register
> is not clocked.
On RDU1, call to usb_phy_init() actually calls usb_gen_phy_init() that
does regulator_enable() for &vusb_reg and clk_prepare_enable() for
&clk_26M_usb. I thing some of these two is actually needed to avoid
hang on register access.
next prev parent reply other threads:[~2018-06-21 14:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 17:34 Andrey Smirnov
2018-05-30 18:10 ` Fabio Estevam
2018-05-31 9:20 ` Nikita Yushchenko
2018-06-20 22:07 ` Fabio Estevam
2018-06-20 22:22 ` Fabio Estevam
2018-06-21 12:47 ` Andrey Smirnov
2018-06-21 14:08 ` Fabio Estevam
2018-06-21 21:44 ` Andrey Smirnov
2018-06-22 16:27 ` Fabio Estevam
2018-06-24 22:40 ` Andrey Smirnov
2018-06-24 23:51 ` Fabio Estevam
2018-06-25 12:18 ` Sebastian Reichel
2018-06-25 12:26 ` Fabio Estevam
2018-06-21 14:12 ` Nikita Yushchenko
2018-06-21 14:25 ` Nikita Yushchenko [this message]
2018-06-22 0:49 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d9fd57-07bc-0bba-2f29-ca778bd85328@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®