From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41387262FF8 for ; Sat, 6 Jun 2026 05:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780722244; cv=none; b=jf/Dl5twYwKTz7w7x3ifma27S5aQwZzTk1edLsAp1N7GBdMOoSOxLgYYQBpY6QE+ScaRj3jia8f5JNl1ufPluk2Q8P6Hk4AiRq+B+wW1j19FXq8ia/Kwt78PaSi8PzGhB5l/EazJBLeZLPIC1nq6R3qctD3yYbcx/bFN9yMCzxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780722244; c=relaxed/simple; bh=263QfBY5Zp+gfX2SSDrodQXz/EAIY/aQ/Pr5s0xl9+Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sIAZV9Bs9FtHzHDhRQHrqT8CgkURyHl4kBLEDZ6keV5ciqdRMbMai5DFTknUQKLaAIfvrEVnA378Jncuo9NyysU1eMFzyqBZ8TIpACTz3r3ncrbUlz3zbY+5YzDGUpiXrN3cl8bjM/XIfm7M9BiLdvBDWsXinTK0CjM50Rg4Q1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net; spf=pass smtp.mailfrom=pardini.net; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b=GZrsoX1z; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pardini.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b="GZrsoX1z" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-6914a658115so716266a12.0 for ; Fri, 05 Jun 2026 22:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pardini.net; s=google; t=1780722242; x=1781327042; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ad3Risuri9Oy23ttuXXObF+tJAD6dYgEl+kDhesPP88=; b=GZrsoX1ziTdDLcdmOAsCHNY+OeE3e5tdgZDTirvyA8VQdLnrB0uiVrpcwwBCPpiH8E 56TTq067Mz7cq3cPfUcoDPjmyBuTkVKUvdjb4cFjhwjC3TblyCh0ymondJHKqduCiCCT YjAdydm+f96c14j8w1y3vGy6sh6tcr/EEZFdfmFqZwWHTG08z5kdLubGIHS1PDl89oEC GbWxqWWc6JxOcLtA7R4rBvZneI1qRMLBKqITxDluKzE17ugE0txz1Cf1j5Nocdm1/EN2 7L0hVwxnfJOIquakxQ5Tyn0x+84uMVWVt641klWNDZKC58IJMzOxDPn6rE+Wvl9R+sc9 BIOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780722242; x=1781327042; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ad3Risuri9Oy23ttuXXObF+tJAD6dYgEl+kDhesPP88=; b=L9Du2GcgkkdQnieWPeJ1M25+j5tUJY6ucDnbhjtHGDD7jX7izKKOVfEu2hs8Xh4qaG ZY/z96XLnbgJJU2/jvcT5VMKY8C+v7gfIor7GjQ2kCyUyW5c92ZhTSOVfqgJ8vE8AqsM +JYx/rj9a61M/f8hJ2aT7ybbKsMxI5VrNvZXwMm2+7N3E+ZyDXPJnAFyISkp9oVMuZk1 2i01xuNNN8UMRelxBn40yKaA6U939UBoGTroMX3PLIIG27KN0ioODgsv0XQJ9exsxiIr wKCooqjlpOW9IEMkpxQJDfguLmaJ9DyV002SAmJO1vHQK910jHqdSXahNRhrHoTCz8u+ plIA== X-Forwarded-Encrypted: i=1; AFNElJ/Zn4TuTGHMJaZQjmpYgGamv0E2W24kQh5ybHtTBtNaaT3Gju8S3X9Cbfj65mZCZIvpa7xvsJYgLf1Cozg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7NxO/DFTWm54cxmbiMb91AdMaYkIJIS8VaXs+ZmCk6abcdm3a g2dMv2QNfmyZv/0YPa8XOAUnDSKWkdYEb2zrHbhv25UP/40mjEzi1nd2pzMlb8kZ9g== X-Gm-Gg: Acq92OGqYou74hM5eK2sosFtMem2a53u9Pc/k2nZD+ma0118oNmSQQr6Rtvn7mGI2t5 kKVDyjIzepc2zGaQGwUss1IiLO9sCvp9xWamlK24b5yK08GFWFfPzL4ux6f07+z/zkt5Eix2/4G /3ITyrLjeo4zA9xkwDhFrSbPB8VEMssWeVu8dhzwZagxB1gz+NCkf+/CE9dRGOCQsDSccmC+Ew6 amgufWe1N8nu2ZeQPrL+DaCIkP1va/GILA1zkA9Asp5MmsQxE/Brk2QHDux50DlfEooKceFU5+E v3JptedOFp5Z6d7f6Mr0yCKfemzTSbPp1AtaS2sTd2N99eOP0083xrPxBQ2d+nkB64v1QYj8W1h 8HtS7VWDPbaCcDrdNptMPGrf7Cx3U9mrEJCmeSf+JeeNu2SXv4ypWuG0AH8FS++NFERZ2Ya7IZV hmpsubMwmvv4lAFyfNog49xMSaanwGlEWJTtG9XxIrmR2C/qpGIXeLJPU0+42VGPmpirGj3HFpI vWvq/wP9ivK8RBFzd4dQstIQRzwymVtFLDcrjRNfpwL//e7fdvloG5zv2A2JTGHn7AEcojG5S9K X-Received: by 2002:a05:6402:268f:b0:68e:4c0:f599 with SMTP id 4fb4d7f45d1cf-68fa4c16b80mr3088882a12.5.1780722241268; Fri, 05 Jun 2026 22:04:01 -0700 (PDT) Received: from ?IPV6:2a02:a466:4d7a:0:c439:8cdb:ad2:c0fb? (2a02-a466-4d7a-0-c439-8cdb-ad2-c0fb.fixed6.kpn.net. [2a02:a466:4d7a:0:c439:8cdb:ad2:c0fb]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6915a637180sm421874a12.26.2026.06.05.22.03.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 22:04:00 -0700 (PDT) Message-ID: <26da1dfa-3408-4654-9046-36ed6d57059c@pardini.net> Date: Sat, 6 Jun 2026 07:03:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: net: add Realtek r8169 family PCIe Ethernet To: Heiner Kallweit , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Sebastian Reichel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-0-8a8857b39daf@pardini.net> <20260605-rk3588-dts-rtl-eth-describe-dt-alias-v3-1-8a8857b39daf@pardini.net> Content-Language: en-US From: Ricardo Pardini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/06/2026 17:48, Heiner Kallweit wrote: > On 05.06.2026 13:49, Ricardo Pardini via B4 Relay wrote: >> From: Ricardo Pardini >> >> Add a binding for fixed/soldered Realtek PCIe Ethernet controllers >> driven by the r8169 driver (RTL8125/8126/8127/8168 and variants). >> >> The "pciVVVV,DDDD" compatibles are the Open Firmware PCI Bus Binding >> spelling, auto-derived from PCI-SIG vendor/device IDs, but they still >> need a binding when used in a board DT - analogous to "usbVVVV,PPPP" >> compatibles documented in their own bindings (e.g. microchip,lan95xx) >> so board DTs attaching properties (fixed MAC, nvmem cell, ...) to >> these PCI function nodes can be validated. >> > > The of node seems to be created by of_pci_make_dev_node(). But this > function is called for bridges only in pci_bus_add_device(). > So where is the node created in your case? Did you test node creation? > Hi Heiner, Seems to me of_pci_make_dev_node() is not at play here - that's the DT-synthesis path. For nodes already present in DT, the of_node is bound earlier, during pci_setup_device() -> pci_set_of_node() -> of_pci_find_child_device() via the 5-cell reg. Ref testing: yes; with this series on a NanoPC-T6 I get, for example: /sys/bus/pci/devices/0004:41:00.0/of_node -> /sys/firmware/devicetree/base/pcie@fe190000/pcie@0,0/ethernet@0,0 and u-boot correctly adds local-mac-address property there which is correctly picked up kernel-side: => setenv eth1addr 8e:b4:90:66:66:66 => boot ... # readlink -f /sys/bus/pci/devices/0004:41:00.0/of_node /sys/firmware/devicetree/base/pcie@fe190000/pcie@0,0/ethernet@0,0 # xxd /sys/bus/pci/devices/0004:41:00.0/of_node/local-mac-address 00000000: 8eb4 9066 6666 ...fff # ip link show dev end1 | grep ether link/ether 8e:b4:90:66:66:66 brd ff:ff:ff:ff:ff:ff >> +properties: >> + compatible: >> + enum: >> + - pci10ec,8125 # RTL8125 2.5GbE >> + - pci10ec,8126 # RTL8126 5GbE >> + - pci10ec,8127 # RTL8127 >> + - pci10ec,8161 # RTL8168 variant >> + - pci10ec,8162 # RTL8168 variant >> + - pci10ec,8168 # RTL8168/8111 GbE > > This list reflects just some of the PCI id's handled by r8169. > Any specific reason for this exact selection? I went for "chips likely to be soldered down on an SBC", but that was indeed speculative. I guess I should trim to pci10ec,8125, which is all this series describes? (further IDs can be added by the patches that introduce boards using them) -- Regards, Ricardo