From: Marek Vasut <marek.vasut@gmail.com>
To: Luis Henriques <henrix@camandro.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: maps: add missing iounmap() in error path
Date: Sun, 20 Nov 2016 22:13:25 +0100 [thread overview]
Message-ID: <26e25b8b-5169-0262-b850-3108cb8d0cde@gmail.com> (raw)
In-Reply-To: <20161116225016.29958-1-henrix@camandro.org>
On 11/16/2016 11:50 PM, Luis Henriques wrote:
> This patch was triggered by the following Coccinelle error:
>
> ./drivers/mtd/maps/sc520cdp.c:246:3-9: \
> ERROR: missing iounmap; ioremap on line 242 \
> and execution via conditional on line 244
>
> Signed-off-by: Luis Henriques <henrix@camandro.org>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> drivers/mtd/maps/sc520cdp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/maps/sc520cdp.c b/drivers/mtd/maps/sc520cdp.c
> index 093edd51bdc7..7a27ed345d0d 100644
> --- a/drivers/mtd/maps/sc520cdp.c
> +++ b/drivers/mtd/maps/sc520cdp.c
> @@ -243,6 +243,10 @@ static int __init init_sc520cdp(void)
>
> if (!sc520cdp_map[i].virt) {
> printk("Failed to ioremap_nocache\n");
> + if (i) {
> + while (--i)
> + iounmap(sc520cdp_map[i].virt);
> + }
> return -EIO;
> }
>
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-11-20 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 22:50 Luis Henriques
2016-11-20 21:13 ` Marek Vasut [this message]
2016-11-22 19:21 ` Brian Norris
2016-11-23 15:22 ` Luis Henriques
2016-11-23 23:40 ` [PATCH v2] " Luis Henriques
2016-11-25 14:18 ` Marek Vasut
2016-12-01 2:32 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26e25b8b-5169-0262-b850-3108cb8d0cde@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=henrix@camandro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome