From: Dave Hansen <dave.hansen@intel.com>
To: Thorsten Blum <thorsten.blum@linux.dev>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Consolidate SME comments and use break
Date: Tue, 9 Jun 2026 07:23:14 -0700 [thread overview]
Message-ID: <26e29657-1e41-4f88-b2f6-8111a3b6e6ff@intel.com> (raw)
In-Reply-To: <20260609113016.296259-2-thorsten.blum@linux.dev>
On 6/9/26 04:30, Thorsten Blum wrote:
> Combine the two SME comments and use break instead of return to exit the
> switch consistently with the other cases.
Hey Thorsten,
While this arguably makes the code a wee bit more consistent, it does it
at the cost of churn. Churn can introduce bugs. It creates conflicts
with other work and it muddies the git history. I don't think the
risk/return on this kind of thing is worth it.
Also, for pure cleanups, I'd personally appreciate seeing them
concentrated really close after -rc1.
next prev parent reply other threads:[~2026-06-09 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 11:30 Thorsten Blum
2026-06-09 14:23 ` Dave Hansen [this message]
2026-06-09 15:32 ` Thorsten Blum
2026-06-09 16:26 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26e29657-1e41-4f88-b2f6-8111a3b6e6ff@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome