From: Marc Zyngier <marc.zyngier@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context
Date: Mon, 4 Sep 2017 18:59:40 +0100 [thread overview]
Message-ID: <26ed6ba5-12ee-909c-4dce-bf84f0620252@arm.com> (raw)
In-Reply-To: <20170904173748.GH26317@leverpostej>
On 04/09/17 18:37, Mark Rutland wrote:
> On Mon, Sep 04, 2017 at 06:30:40PM +0100, Marc Zyngier wrote:
>> Booting a DEBUG_PREEMPT enabled kernel on a CCN-based system
>> results in the following splat:
>>
>> [...]
>> arm-ccn e8000000.ccn: No access to interrupts, using timer.
>> BUG: using smp_processor_id() in preemptible [00000000] code: swapper/0/1
>> caller is debug_smp_processor_id+0x1c/0x28
>> CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.13.0 #6111
>> Hardware name: AMD Seattle/Seattle, BIOS 17:08:23 Jun 26 2017
>> Call trace:
>> [<ffff000008089e78>] dump_backtrace+0x0/0x278
>> [<ffff00000808a22c>] show_stack+0x24/0x30
>> [<ffff000008bc3bc4>] dump_stack+0x8c/0xb0
>> [<ffff00000852b534>] check_preemption_disabled+0xfc/0x100
>> [<ffff00000852b554>] debug_smp_processor_id+0x1c/0x28
>> [<ffff000008551bd8>] arm_ccn_probe+0x358/0x4f0
>> [...]
>>
>> as we use smp_processor_id() in the wrong context. Turning this
>> into a get_cpu()/put_cpu() does the trick.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> drivers/bus/arm-ccn.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
>> index e8c6946fed9d..8502f1767024 100644
>> --- a/drivers/bus/arm-ccn.c
>> +++ b/drivers/bus/arm-ccn.c
>> @@ -1297,7 +1297,8 @@ static int arm_ccn_pmu_init(struct arm_ccn *ccn)
>> }
>>
>> /* Pick one CPU which we will use to collect data from CCN... */
>> - cpumask_set_cpu(smp_processor_id(), &ccn->dt.cpu);
>> + cpumask_set_cpu(get_cpu(), &ccn->dt.cpu);
>> + put_cpu();
>
> I think this isn't quite right, and we need to keep a CPU online until
> we've registerd the hotplug callbacks. Otherwise, we could race with a
> concurrent hotplug, and not migrate events appropriately.
Right, I see. I'll respin that.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2017-09-04 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 17:30 [PATCH 0/2] bus: CCN/CCI: Fix use of smp_processor_id() Marc Zyngier
2017-09-04 17:30 ` [PATCH 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context Marc Zyngier
2017-09-04 17:37 ` Mark Rutland
2017-09-04 17:59 ` Marc Zyngier [this message]
2017-09-04 17:30 ` [PATCH 2/2] bus: arm-cci: " Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26ed6ba5-12ee-909c-4dce-bf84f0620252@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®