mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Kunwu Chan" <chentao@kylinos.cn>,
	xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Ingo Molnar" <mingo@redhat.com>, "Jürgen Groß" <jgross@suse.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	x86@kernel.org
Cc: kernel test robot <lkp@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	Jean Delvare <jdelvare@suse.de>, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c
Date: Sat, 20 Jan 2024 15:45:11 +0100	[thread overview]
Message-ID: <26ef811d-214c-4ce4-a9f8-4fa4cfdefe29@web.de> (raw)
In-Reply-To: <20240119094948.275390-1-chentao@kylinos.cn>

> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.

How do you think about to refer to the function name
instead of the file name in the patch subject?


…
> +++ b/arch/x86/xen/smp.c
…
> @@ -114,6 +124,8 @@ int xen_smp_intr_init(unsigned int cpu)
>
>  	return 0;
>
> + fail_mem:
> +	rc = -ENOMEM;
>   fail:
>  	xen_smp_intr_free(cpu);
>  	return rc;

Is it currently preferred to start labels in the first text column?

Regards,
Markus

  parent reply	other threads:[~2024-01-20 14:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19  9:49 Kunwu Chan
2024-01-19 10:40 ` Markus Elfring
2024-01-22  7:47   ` Kunwu Chan
2024-01-20 14:45 ` Markus Elfring [this message]
2024-01-22  7:43   ` Kunwu Chan
2024-01-22  9:50     ` [v3] " Markus Elfring
2024-02-12 17:07 ` [PATCH v3] " Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26ef811d-214c-4ce4-a9f8-4fa4cfdefe29@web.de \
    --to=markus.elfring@web.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=chentao@kylinos.cn \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=idryomov@gmail.com \
    --cc=jdelvare@suse.de \
    --cc=jgross@suse.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®