From: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
To: Vasily Averin <vasily.averin@linux.dev>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>,
Jason Wang <jasowang@redhat.com>
Cc: kernel@openvz.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] Create debugfs file with virtio balloon usage information
Date: Tue, 28 Jun 2022 16:03:50 +0300 [thread overview]
Message-ID: <26f462fd-687a-aaf9-55f6-7b5414709dca@virtuozzo.com> (raw)
In-Reply-To: <e20dccc7-8ab6-7c15-7088-e82e67e7ad48@linux.dev>
Hello,
On 28/06/2022 15:55, Vasily Averin wrote:
> On 6/28/22 12:23, Alexander Atanasov wrote:
>> +static int virtio_balloon_debug_show(struct seq_file *f, void *offset)
>> +{
>> + struct virtio_balloon *b = f->private;
>> + u32 num_pages;
>> + struct sysinfo i;
>> +
>> + si_meminfo(&i);
>> +
>> + seq_printf(f, "%-22s: %d\n", "page_size", 4096);
> This output of the constant looks strange for me.
> Could you please explain why this is required?
Ballon driver always works in 4K page units. The values in the file are in the driver units.
Guests need it to be able to perform calculations of actual values.
In the case of virtio_balloon it is always 4K but other balloon drivers can have different page_sizes.
--
Regards,
Alexander Atanasov
prev parent reply other threads:[~2022-06-28 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 12:20 [PATCH " alexander.atanasov
2022-06-27 12:59 ` Michael S. Tsirkin
2022-06-27 19:19 ` Alexander Atanasov
2022-06-27 20:42 ` Michael S. Tsirkin
2022-06-28 9:07 ` Alexander Atanasov
2022-06-28 9:23 ` [PATCH v3 " Alexander Atanasov
2022-06-28 12:55 ` Vasily Averin
2022-06-28 13:03 ` Alexander Atanasov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26f462fd-687a-aaf9-55f6-7b5414709dca@virtuozzo.com \
--to=alexander.atanasov@virtuozzo.com \
--cc=david@redhat.com \
--cc=jasowang@redhat.com \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=vasily.averin@linux.dev \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®