From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>, kvm@vger.kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2 2/4] KVM: x86: add more information to the kvm_entry tracepoint
Date: Tue, 26 Sep 2023 18:39:00 +0200 [thread overview]
Message-ID: <27053c89-e11c-e16d-ef88-89b3cd99c487@redhat.com> (raw)
In-Reply-To: <20230924124410.897646-3-mlevitsk@redhat.com>
On 9/24/23 14:44, Maxim Levitsky wrote:
> + __field( u32, inj_info )
> + __field( u32, inj_info_err )
> + __field( bool, guest_mode )
> + __field( bool, req_imm_exit )
> + ),
As anticipated in patch 1 I'm not so sure about adding req_imm_exit here
but also (especially) in kvm_exit. I do believe it should be traced,
I'm not sure it's needed in kvm_entry+kvm_exit as opposed to just a
separate tracepoint.
Paolo
next prev parent reply other threads:[~2023-09-26 16:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 12:44 [PATCH v2 0/4] KVM: x86: tracepoint updates Maxim Levitsky
2023-09-24 12:44 ` [PATCH v2 1/4] KVM: x86: refactor req_immediate_exit logic Maxim Levitsky
2023-09-26 16:37 ` Paolo Bonzini
2023-09-28 10:41 ` Maxim Levitsky
2023-09-24 12:44 ` [PATCH v2 2/4] KVM: x86: add more information to the kvm_entry tracepoint Maxim Levitsky
2023-09-26 16:39 ` Paolo Bonzini [this message]
2023-09-28 10:41 ` Maxim Levitsky
2023-09-24 12:44 ` [PATCH v2 3/4] KVM: x86: add more information to kvm_exit tracepoint Maxim Levitsky
2023-09-26 16:40 ` Paolo Bonzini
2023-09-28 10:41 ` Maxim Levitsky
2023-09-24 12:44 ` [PATCH v2 4/4] KVM: x86: add new nested vmexit tracepoints Maxim Levitsky
2023-09-26 16:50 ` Paolo Bonzini
2023-09-28 10:42 ` Maxim Levitsky
2023-09-26 0:03 ` [PATCH v2 0/4] KVM: x86: tracepoint updates Sean Christopherson
2023-09-26 8:28 ` Maxim Levitsky
2023-09-26 16:36 ` Paolo Bonzini
2023-09-26 20:45 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27053c89-e11c-e16d-ef88-89b3cd99c487@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome