From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753007AbdEJPIB (ORCPT <rfc822;w@1wt.eu>);
        Wed, 10 May 2017 11:08:01 -0400
Received: from mx08-00252a01.pphosted.com ([91.207.212.211]:42021 "EHLO
        mx08-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751118AbdEJPIA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 May 2017 11:08:00 -0400
Subject: Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm
To: Marc Zyngier <marc.zyngier@arm.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20170510132620.19685-1-marc.zyngier@arm.com>
 <2c3f16ea-8806-9ae8-9bae-02e198a59092@arm.com>
Cc: Eric Anholt <eric@anholt.net>, Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>
From: Phil Elwell <phil@raspberrypi.org>
Message-ID: <27076f41-1616-ea16-6422-11692f95bdec@raspberrypi.org>
Date: Wed, 10 May 2017 16:07:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <2c3f16ea-8806-9ae8-9bae-02e198a59092@arm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-10_11:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000
 definitions=main-1705100103
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/2017 14:32, Marc Zyngier wrote:
> On 10/05/17 14:26, Marc Zyngier wrote:
>> One of the RPi-2/3 irqchip's key features is that it contains some
>> SMP startup code for the 32bit ARM architecture version. The only
>> reason I can imagine for this is "RPi is special".
>>
>> Let's move this code where it belongs (in the platform support code),
>> creating a shared include file for this purpose.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> 
> Also:
> Fixes: 41f4988cc287 ("irqchip/bcm2836: Add SMP support for the 2836")
> 
> 	M.
> 

The patch has some checkpatch warnings, but otherwise:

Reviewed-by: Phil Elwell <phil@raspberrypi.org>
Tested-by: Phil Elwell <phil@raspberrypi.org>

Thanks,

Phil