mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, Pavel Machek <pavel@ucw.cz>,
	Len Brown <len.brown@intel.com>,
	od@zcrc.me, linux-mmc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/3] PM: introduce pm_ptr() macro
Date: Sun, 26 Apr 2020 17:40:43 +0200	[thread overview]
Message-ID: <2708095.iQXV2FnTNx@kreacher> (raw)
In-Reply-To: <20200413123207.74552-1-paul@crapouillou.net>

On Monday, April 13, 2020 2:32:05 PM CEST Paul Cercueil wrote:
> This macro is analogous to the infamous of_match_ptr(). If CONFIG_PM
> is enabled, this macro will resolve to its argument, otherwise to NULL.

Well, this is going to result in quite a bit of unused code being
added to the kernels built with CONFIG_PM unset.

Is there any way to avoid that somehow?

> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
> Notes:
>     v2: Remove pm_sleep_ptr() macro
> 
>  include/linux/pm.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index e057d1fa2469..1c0eec06905d 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -374,6 +374,12 @@ const struct dev_pm_ops name = { \
>  	SET_RUNTIME_PM_OPS(suspend_fn, resume_fn, idle_fn) \
>  }
>  
> +#ifdef CONFIG_PM
> +#define pm_ptr(_ptr) (_ptr)
> +#else
> +#define pm_ptr(_ptr) NULL
> +#endif
> +
>  /*
>   * PM_EVENT_ messages
>   *
> 





  parent reply	other threads:[~2020-04-26 15:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13 12:32 Paul Cercueil
2020-04-13 12:32 ` [PATCH v2 2/3] PM: Make *_DEV_PM_OPS macros use __maybe_unused Paul Cercueil
2020-04-13 12:32 ` [PATCH v2 3/3] mmc: jz4740: Use pm_ptr() macro Paul Cercueil
2020-04-21 10:39   ` Ulf Hansson
2020-04-26 15:40 ` Rafael J. Wysocki [this message]
2020-04-26 17:06   ` [PATCH v2 1/3] PM: introduce " Paul Cercueil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2708095.iQXV2FnTNx@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    --cc=pavel@ucw.cz \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®