mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Falcon, Thomas" <thomas.falcon@intel.com>
To: "tj@kernel.org" <tj@kernel.org>
Cc: "mkoutny@suse.com" <mkoutny@suse.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>
Subject: Re: [RFC PATCH] cgroup/rstat: convert rstat lock from spinlock to rwlock
Date: Tue, 19 May 2026 18:04:33 +0000	[thread overview]
Message-ID: <27091d075bc264a0d33b01dd105389e0dc39d862.camel@intel.com> (raw)
In-Reply-To: <agyisB5nfUdDBCk5@slm.duckdns.org>

On Tue, 2026-05-19 at 07:49 -1000, Tejun Heo wrote:
> On Tue, May 19, 2026 at 12:31:34PM -0500, Thomas Falcon wrote:
> > Implement rstat_ss_lock and rstat_base_lock as read-write locks
> > instead of spinlocks. In addition, update tracing to reflect new
> > locking implementation.
> > 
> > The benchmark below, meant to simulate a workload performing many
> > concurrent cgroup cpu.stat reads, completes in 134 seconds on an
> > Intel
> > Xeon Platinum 8568Y with 144 cpus compared to 241 seconds when
> > using spinlocks.
> 
> Can you try using seqlock for readers? That'd be decouple readers a
> lot
> better than rwlocks.
> 
> Thanks.
> 
Hi, thanks for the quick response. I will try that.

Thanks,
Tom

  reply	other threads:[~2026-05-19 18:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 17:31 Thomas Falcon
2026-05-19 17:49 ` Tejun Heo
2026-05-19 18:04   ` Falcon, Thomas [this message]
2026-05-22 16:08 ` Michal Koutný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27091d075bc264a0d33b01dd105389e0dc39d862.camel@intel.com \
    --to=thomas.falcon@intel.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®