Re: [PATCH v2 2/5] dt-bindings: display: Add the Ingenic X1600 LCD controller

[Paul Cercueil <paul@crapouillou.net>]

Hi Krzysztof,

Le mardi 27 octobre 2026 à 12:00 +0100, Krzysztof Kozlowski a écrit :
> On Sun, Oct 25, 2026 at 08:16:37PM +0100, Olivier Louvignes wrote:
> > The X1600's display controller fetches frames through descriptors
> > and
> > keeps its interface and timings in register blocks of their own
> > (X1600
> > programming manual, chapter 10), so it shares nothing with the
> > controllers ingenic,lcd.yaml describes. Its registers are those of
> > the
> > X2000's display controller without the composer.
> > 
> > Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
> > ---
> >  .../bindings/display/ingenic,x1600-lcd.yaml   | 70
> > +++++++++++++++++++
> >  MAINTAINERS                                   |  5 ++
> >  2 files changed, 75 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/ingenic,x1600-lcd.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/ingenic,x1600-lcd.yaml
> > b/Documentation/devicetree/bindings/display/ingenic,x1600-lcd.yaml
> > new file mode 100644
> > index 000000000000..171536c78f4b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/ingenic,x1600-
> > lcd.yaml
> > @@ -0,0 +1,70 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/ingenic,x1600-lcd.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Ingenic X1600 LCD controller
> > +
> > +maintainers:
> > +  - Olivier Louvignes <olivier@mgcrea.io>
> > +
> > +description:
> > +  The display controller of the Ingenic X1600 SoC. It fetches
> > frames through
> > +  descriptors in memory and drives a parallel RGB panel or a smart
> > panel;
> > +  its registers have nothing in common with the controllers
> > described in
> > +  ingenic,lcd.yaml.
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: "^lcd-controller@[0-9a-f]+$"
> 
> Individual device schemas do not need to enforce naming, you can drop
> nodename.
> 
> > +
> > +  compatible:
> > +    const: ingenic,x1600-lcd
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: The pixel clock, whose gate also gates the
> > controller
> > +
> > +  clock-names:
> > +    items:
> > +      - const: lcd
> 
> ... and drop clock-names, since it is the same as device name.
> 
> > +
> > +  port:
> > +    $ref: /schemas/graph.yaml#/properties/port
> > +    description: The output, to the panel or bridge.
> 
> No port for IPU?

No IPU on the X1600 - the display IP is completely different there
(hence the new binding).

Cheers,
-Paul