From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Jonghwan Choi <jhbird.choi@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Jonghwan Choi <jhbird.choi@samsung.com>
Subject: Re: [PATCH 4/4] PM / devfreq: Consider hibernation in pm notifier
Date: Tue, 19 Nov 2013 15:50:05 +0100 [thread overview]
Message-ID: <27161890.Zx6CiZOMr8@amdc1032> (raw)
In-Reply-To: <1384867831-15383-1-git-send-email-jhbird.choi@samsung.com>
Hi,
Are you planning to add hibernation support to ARM?
If so then this should be stated somewhere in the patch description.
OTOH if you are not going to add hibernation support to ARM I see
a little sense in adding hibernation support to ARM-only drivers..
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Tuesday, November 19, 2013 10:30:31 PM Jonghwan Choi wrote:
> Frequency lock should be considered in suspend/hibernation.
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/devfreq/exynos/exynos5_bus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/devfreq/exynos/exynos5_bus.c b/drivers/devfreq/exynos/exynos5_bus.c
> index a60da3c..bd672de0 100644
> --- a/drivers/devfreq/exynos/exynos5_bus.c
> +++ b/drivers/devfreq/exynos/exynos5_bus.c
> @@ -268,6 +268,7 @@ static int exynos5_busfreq_int_pm_notifier_event(struct notifier_block *this,
> int err = 0;
>
> switch (event) {
> + case PM_HIBERNATION_PREPARE:
> case PM_SUSPEND_PREPARE:
> /* Set Fastest and Deactivate DVFS */
> mutex_lock(&data->lock);
> @@ -300,6 +301,7 @@ unlock:
> if (err)
> return NOTIFY_BAD;
> return NOTIFY_OK;
> + case PM_POST_HIBERNATION:
> case PM_POST_RESTORE:
> case PM_POST_SUSPEND:
> /* Reactivate */
next prev parent reply other threads:[~2013-11-19 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 13:30 Jonghwan Choi
2013-11-19 14:50 ` Bartlomiej Zolnierkiewicz [this message]
2013-11-19 22:08 ` Sebastian Capella
2013-11-20 9:51 ` MyungJoo Ham
2013-11-20 9:46 ` MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27161890.Zx6CiZOMr8@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=jhbird.choi@gmail.com \
--cc=jhbird.choi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®