From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbdBIMau (ORCPT ); Thu, 9 Feb 2017 07:30:50 -0500 Received: from smtprelay0203.hostedemail.com ([216.40.44.203]:42857 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751157AbdBIMas (ORCPT ); Thu, 9 Feb 2017 07:30:48 -0500 X-Session-Marker: 69616E406162626F74742E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,abbotti@mev.co.uk,:::::::::,RULES_HIT:41:355:379:599:800:960:967:973:988:989:1260:1261:1263:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1539:1593:1594:1683:1711:1730:1747:1777:1792:1801:2393:2525:2560:2563:2612:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3000:3022:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4605:5007:7514:7652:7903:9025:10004:10400:10848:11232:11658:11914:12050:12740:12760:12895:13069:13255:13311:13357:14096:14097:14181:14571:14685:14721:14764:14777:21080:21451:30021:30051:30054,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: owl52_2f2d3e7bc2806 X-Filterd-Recvd-Size: 1773 Subject: Re: [PATCH] Staging: comedi: drivers: comedi_test: Set max input value for auto config To: Cheah Kok Cheong , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1485365489-3577-1-git-send-email-thrust73@gmail.com> <1485532554-2520-1-git-send-email-thrust73@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <271653cb-b0d9-dcb9-0bfb-e6282221cf02@mev.co.uk> Date: Thu, 9 Feb 2017 12:28:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <1485532554-2520-1-git-send-email-thrust73@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/01/17 15:55, Cheah Kok Cheong wrote: > Currently user can input any value for amplitude and period. > This patch set a sane max value for auto-configuration mode. > > For manual configuration mode, it is assumed this is taken care of > by the COMEDI userspace tool since there's no limit set here from > day one in the staging tree. If otherwise then maybe this can be > looked at separately. > > Signed-off-by: Cheah Kok Cheong I don't think there is any need to limit these unless it results in arithmetic overflow, since they only affect the fake sample data values produced by the driver, not system performance. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-