From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754948AbbK0Pwi (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Nov 2015 10:52:38 -0500
Received: from mout.kundenserver.de ([212.227.126.187]:52634 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754285AbbK0Pwh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Nov 2015 10:52:37 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>, robh+dt@kernel.org,
        pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        michals@xilinx.com, sorenb@xilinx.com, bhelgaas@google.com,
        tinamdar@apm.com, treding@nvidia.com, rjui@broadcom.com,
        Minghuan.Lian@freescale.com, m-karicheri2@ti.com, hauke@hauke-m.de,
        marc.zyngier@arm.com, dhdang@apm.com, sbranden@broadcom.com,
        devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Bharat Kumar Gogada <bharatku@xilinx.com>,
        Ravi Kiran Gummaluri <rgummal@xilinx.com>
Subject: Re: [PATCH v10] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller
Date: Fri, 27 Nov 2015 16:51:38 +0100
Message-ID: <2717087.4cxEA98ZJk@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1448636523-20503-1-git-send-email-bharatku@xilinx.com>
References: <1448636523-20503-1-git-send-email-bharatku@xilinx.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:4vEo2mL/0DMVEwVCC7Z3RerwuvH9cCHMs38DHXTQoG6CG54lRfy
 oIHKE7QXDVdgy1TIwJ3YB9/oI72WAQ/vwLVhZjK5Jra5A6pUSGvKdTFCqt4M5WBs+1ffLDs
 xDjWwZAbUD7gTKF7UvOYz/DGVATOj2HRRdiESFHwnT3A3N/dpshNn6ScjHGR5qXsQnVO7yq
 hzGTl9DWRDuELPkXE5QXw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:BsWcsreiDTw=:YZDKJ9hH9XGB6DTh5pI95e
 2sVrLZ/3zEp7xul8VhotDdZXrZ7jiIDWoyTY/qtNwYjZ+hSU1MWmtg+uSF1z0FBOuOPLE/aJs
 D5fqLoOd6yg83lBTRtaOxGpBq0+zi50Tg26uji38STkLDz2NR+elpKWAAddoDToJ4IWHlVHTh
 v4o+FW5wS63W2H2XV1XcHunEeZFGe/j4+gSmlBbE0DTMsLn0G6BMZd/jSP71LMYuPm5NqZXCd
 wq2gp1QdU5sOTafdStuPZenOKe/LqKmCqS2h8r0xeZJBpoe0QLSeIZbBKScSJFbmb7I/uCNX0
 x5K8gNuMTRWhORfpJrpl0SM9liOoPY8SdR1wWrdy46LpZ4cWrGexPluffQr8cpKAcKO0kj52N
 0jNmF6t/9bB8nb/++i4k6INtKhsXA4YLCVzEJQRMuE7/JqisRJwq3OyIv+7xerE50XxqCr+v+
 /mfPACPQBupFA0pe8tMlClksMfNbShlCAqHh7gJ1BGKh+jueKOIvzhpgpAI0k/jahdF/yr9vy
 Q3ZR9dFzLIPYT2SNR9Hn+wlTAGYT8iASZ3lS5jdbotEiAtfAWMxMfHII5Fnmlb8rg0tfre97k
 K/8lAL9JNwKEYySzUVemrP2/2kBS7m/JuWJtwzmVypt4IKsJo4oopxtgqrwcsEFF4Cgz8+DxO
 bNwon05IU/tDobUwuWhsgh/lw6s0wGUELaeL4dEKZPK/qSrni4DF1M5xWqSnpqrBQB8bgQvcn
 lWE/2KahKaDe+SN8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 27 November 2015 20:32:03 Bharat Kumar Gogada wrote:
> +       do {
> +               err = nwl_pcie_link_up(pcie, PHY_RDY_LINKUP);
> +               if (err != 1) {
> +                       check_link_up++;
> +                       if (check_link_up > LINKUP_ITER_CHECK)
> +                               return -ENODEV;
> +                       mdelay(1000);
> +               }
> +       } while (!err);

mdelay(1000) is not something anyone should do. Why can't you call
a sleeping function here?

	Arnd