mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fan Wu <wufan@kernel.org>
To: Manuel Huber <manuelh@nvidia.com>,
	David Howells <dhowells@redhat.com>,
	Jarkko Sakkinen <jarkko@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
	Andrew Halaney <andrew@amutable.com>,
	Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Shuah Khan <shuah@kernel.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	"linux-security-module@vger.kernel.org"
	<linux-security-module@vger.kernel.org>,
	"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 1/4] ipe: add the .ipe policy keyring
Date: Tue, 27 Oct 2026 13:51:14 -0700	[thread overview]
Message-ID: <271e8930-471e-4685-bed7-756748cb1baf@kernel.org> (raw)
In-Reply-To: <DM4PR12MB6136C6E1BE1E6D675AFFF0EDDE602@DM4PR12MB6136.namprd12.prod.outlook.com>

On 10/27/2026 1:12 PM, Manuel Huber wrote:
> On Mon, Oct 19, 2026 at 04:15:57PM -0700, Fan Wu wrote:
>> I would prefer a Kconfig CONFIG_SECURITY_IPE_KEYRING default to N instead,
>> like the fsverity keyring. In the kconfig you can also describe in which
>> cases should this option be turned on.
> 
> Thanks to everyone for the discussion. Some of the points raised are
> actionable, but two review questions still seem to be open:
> 
> 1. Whether to use CONFIG_SECURITY_IPE_KEYRING or the 'per-boot
>    provisioning' pattern with a kernel command-line parameter
> 2. Whether IPE should accept any irreversible keyring restriction or
>    specifically mandate restrict_link_reject.
> 
> I want to remain completely neutral here because I am only a potential
> first-time contributor, and because the scenario I elaborated on can be
> realized with either resolution. Fan, would you prefer that I:
> 
> a. move forward with a non-RFC v2 incorporating your initial
>    suggestions;
> b. revise the suggestions given the subsequent discussion; or
> c. wait for more input before making a decision?
> 
> Apologies if this follow-up causes unnecessary churn and turnovers. If
> the thread remains quiet, I will proceed with (a).

I would prefer using a Kconfig option to enable the keyring itself. If
you want a kernel command-line parameter, please gate it behind a
separate Kconfig option and document the detailed scenario for how you
intend to use it.

The same applies to the keyring restriction check.

I also suggest adding a dedicated threat model discussion in your next
version. The proposed model drifts significantly from IPE's current
threat model, where the root of trust comes from the kernel image or
firmware, and please also address the kexec interaction that Luca
pointed out.

Fan

  reply	other threads:[~2026-10-27 20:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 21:40 [PATCH RFC 0/4] IPE: add a dedicated " Manuel Huber via B4 Relay
2026-10-19 21:40 ` [PATCH RFC 1/4] ipe: add the .ipe " Manuel Huber via B4 Relay
2026-10-19 21:52   ` Randy Dunlap
2026-10-19 23:15   ` Fan Wu
2026-10-21 13:54     ` Christian Brauner
2026-10-21 16:51       ` Paul Moore
2026-10-22 10:18         ` Christian Brauner
2026-10-22 17:18           ` Paul Moore
2026-10-26 12:57             ` luca.boccassi
2026-10-27 11:07               ` Luca Boccassi
2026-10-28 12:42                 ` James Bottomley
2026-10-28 14:26                   ` Luca Boccassi
2026-10-28 16:14                     ` James Bottomley
2026-10-22 18:01     ` Manuel Huber
2026-10-22 20:25       ` Fan Wu
2026-10-23 11:59         ` Christian Brauner
2026-10-27 20:12     ` Manuel Huber
2026-10-27 20:51       ` Fan Wu [this message]
2026-10-19 21:40 ` [PATCH RFC 2/4] keys: add KEY_SPEC_IPE_KEYRING Manuel Huber via B4 Relay
2026-10-19 23:24   ` Fan Wu
2026-10-21 13:51     ` Christian Brauner
2026-10-19 21:40 ` [PATCH RFC 3/4] Documentation: ipe: document the IPE keyring Manuel Huber via B4 Relay
2026-10-19 21:40 ` [PATCH RFC 4/4] selftests/ipe: test the IPE policy keyring Manuel Huber via B4 Relay
2026-10-19 23:28   ` Fan Wu
2026-10-22 17:22     ` Manuel Huber
2026-10-19 21:54 ` [PATCH RFC 0/4] IPE: add a dedicated " Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=271e8930-471e-4685-bed7-756748cb1baf@kernel.org \
    --to=wufan@kernel.org \
    --cc=andrew@amutable.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=dhowells@redhat.com \
    --cc=jarkko@kernel.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=manuelh@nvidia.com \
    --cc=paul@paul-moore.com \
    --cc=rdunlap@infradead.org \
    --cc=serge@hallyn.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®