From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753798AbdIDN6M (ORCPT ); Mon, 4 Sep 2017 09:58:12 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:28190 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753664AbdIDN6J (ORCPT ); Mon, 4 Sep 2017 09:58:09 -0400 X-AuditID: b6c32a48-f79a16d00000362a-96-59ad5bef554a From: Bartlomiej Zolnierkiewicz To: "Gustavo A. R. Silva" Cc: Thomas Winischhofer , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: sis: fix duplicated code for different branches Date: Mon, 04 Sep 2017 15:58:01 +0200 Message-id: <2720040.oNlgtMK5vT@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170830131942.GA8173@embeddedgus> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsWy7bCmue776LWRBh8Pylps3aNqcaLvA6vF 5V1z2CxWr3zM7sDise6gqsfnTXIeC2b8ZwlgjuKySUnNySxLLdK3S+DKuL9lHUvBDuaKu288 GhifMnUxcnBICJhIHJzL2cXICWSKSVy4t56ti5GLQ0hgB6PEv2fnmSGc74wSxxd/YIdpmNdl ARHfzSjxe/FvdgjnK6NEz9xmJpBRbAJWEhPbVzGC2CICRhKzZ3SzgtjMAnkStyccYwUZJCwQ IrH+tT5ImEVAVeL3/WfMIDavgKbE+jkPwFpFBbwktuxrBxvJKWAg0XFqORtEjaDEj8n3WCBG ykvs2z8VaryOxNlj6xhB7pEQmMIm8W7zWRaIo10k3i50gPhSWOLV8S3sELa0xLNVGxkh7OmM Ett/S0D0bmaUWLV7AlSRtcTh4xehFvBJdBz+Cw0IXomONiGIEg+Js+tnMUPYjhLt05tZIGHS zCjR+egF4wRGuVlI7p6F5O5ZSO5ewMi8ilEstaA4Nz212KjARK84Mbe4NC9dLzk/dxMjOAFo eexgPHDO5xCjAAejEg/vhvC1kUKsiWXFlbmHGCU4mJVEeE8EA4V4UxIrq1KL8uOLSnNSiw8x SnOwKInz1m27FiEkkJ5YkpqdmlqQWgSTZeLglGpgZA4ylU2pn7z/lr6lxAeX0AMuuiK3vY0L z9hP9GrgmFTMeCUjuXn6iSV58ec45h2qvBzxauUye1OWrHTZzrvWRvP5vedvKandmVs/9eaM ZVvk+Y89DWBTttsTq1BxI93qRHLCxGUdbfNnvRXZlLF4m97Z1Xe11LM29V241KD7VjWmT6Fl 8eJdSizFGYmGWsxFxYkAALAFEPwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGLMWRmVeSWpSXmKPExsVy+t9jAd130WsjDR79NLbYukfV4kTfB1aL y7vmsFmsXvmY3YHFY91BVY/Pm+Q8Fsz4zxLAHMVlk5Kak1mWWqRvl8CVcX/LOpaCHcwVd994 NDA+Zepi5OCQEDCRmNdl0cXIxSEksJNR4mDza6A4J5DzlVFi3bcAEJtNwEpiYvsqRhBbRMBI YvaMblYQm1kgT6L51QqwOcICIRLrX+uDhFkEVCV+33/GDGLzCmhKrJ/zAKxVVMBLYsu+drDx nAIGEh2nlrNB7G1llPi+8icLRIOgxI/J91gg5stL7Ns/FWqXlsT6nceZJjDyz0JSNgtJ2Swk ZQsYmVcxSqYWFOem5xYbFRjlpZbrFSfmFpfmpesl5+duYgSG5rbDWv07GB8viT/EKMDBqMTD uyF8baQQa2JZcWXuIUYJDmYlEd4TwUAh3pTEyqrUovz4otKc1OJDjNIcLErivJl9MyKFBNIT S1KzU1MLUotgskwcnFINjHVnzRi/l78XPeO/aX/vp11rd87c4LMzwPPxYaVr3zSOX7Je9IFj 4/1Pqx25unjby1aYtcyU2OOSI33i3/c3rgIhMw1XzYyyixM5fY7lrni1eV7d1YkBJt8+s7+4 vNiXZw5/9fN4V6cztq6Hn3Fcu7iJl7H1bK37N8HThmVSLE+Pli9vV1j+uEaJpTgj0VCLuag4 EQCThg+cSQIAAA== X-CMS-MailID: 20170904135806epcas2p339bc215adb184ecc1f90a358912805ec X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170830131945epcas1p47e42f63ff4ae1d88501d4750ad455618 X-RootMTR: 20170830131945epcas1p47e42f63ff4ae1d88501d4750ad455618 References: <20170830131942.GA8173@embeddedgus> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 30, 2017 08:19:42 AM Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1226761 > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics