From: Ludovic BARRE <ludovic.barre@st.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity
Date: Mon, 21 Sep 2020 11:26:44 +0200 [thread overview]
Message-ID: <272066d2-35db-0441-a49d-9315894ae674@st.com> (raw)
In-Reply-To: <20200612072901.14388-1-ludovic.barre@st.com>
Hi Marc
Just a gentleman ping about this patch.
I verified, you could always apply this patch on linux master branch.
Regards
Ludo
Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit :
> exti hardware point of view, there is no specific action on set_affinity.
> So the affinity must be forwarded to parent if there is a
> descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
> drivers/irqchip/irq-stm32-exti.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index faa8482c8246..1a0a60ee7140 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
> if (d->parent_data->chip)
> return irq_chip_set_affinity_parent(d, dest, force);
>
> - return -EINVAL;
> + return IRQ_SET_MASK_OK_DONE;
> }
>
> static int __maybe_unused stm32_exti_h_suspend(void)
>
prev parent reply other threads:[~2020-09-21 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 7:29 Ludovic Barre
2020-09-21 9:26 ` Ludovic BARRE [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=272066d2-35db-0441-a49d-9315894ae674@st.com \
--to=ludovic.barre@st.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®