From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932123AbbLJIGH (ORCPT ); Thu, 10 Dec 2015 03:06:07 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:61895 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753724AbbLJIFq (ORCPT ); Thu, 10 Dec 2015 03:05:46 -0500 From: Arnd Bergmann To: xuejiancheng Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, suwenping@hisilicon.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, yanhaifeng@hisilicon.com, gaofei@hisilicon.com, ml.yang@hisilicon.com, yanghongwei@hisilicon.com Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board Date: Thu, 10 Dec 2015 09:04:10 +0100 Message-ID: <2721289.3GUub5trUg@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56691C65.6090808@huawei.com> References: <1449110668-23647-1-git-send-email-xuejiancheng@huawei.com> <5533669.m0KDLq8XOc@wuerfel> <56691C65.6090808@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:p7/BQi4vuLwJwe8rW8yTVB1YKM341HDPc7tsGoppE3eJ4dglceu aad2z/Ixa8rOGyXfRJx2PtrwONtVth3foDhkPBRDVkXxh5b80cp1J0DwMWZDNkfm61w+PcE rYyqWgll/65Dnzmrga/30fGWM6iIM3/7P9m5TVa003FdUtYXBgOs03lQDyMB0ZrmxMbYb8y wC8A2wpoYzVSH1k3oat1w== X-UI-Out-Filterresults: notjunk:1;V01:K0:EcaWuiMjk1w=:VWb4DQxrtKArYbQavrHMRa cdqKPREWJQZ1k+Nu6iSp8kTPJmvwU9wnzEMy8yi+gSzPx5+DkZ5/5fyBss9C3K0YE9Oh5cqoE oWVlHGYdWzrfB0U301wbhFs+1MaD0gtpgnH68OLyaNFW6YNu9w5joRXXSIoxL9vjEmG3EtVCI S80rzD93g7hVWpfvp3CiqgpCkDeL85Eo1u+aPtjIp0KvOz3NhV4JEqnHvjFJXLJ9qHgDaNXY6 KjjBpdtKfXh2MPp49/n/I1tIMQnOJANi/x9kYYdZSgRgcZF2BiJVwyVdk+jcwvIqTgE0Gc+TE RliH3PEBLkne1AdnOQzRoRT9AiWbVO0V762XYuTLUVSQMeEx2gOJlqk/XYn/oCpE8/jOpbNH7 1WJmvvnb/W7SlRLCujzqcfwhmXxIX305oH0vdkP2PhayKtlgyQ42M06ek5sGRm25SXaoPxA8N YyB9vaS3nJB9BYHC9mJo1nSEAxRyGJCK5eZLxU4kVKaq6FSnBxNmsmy/wy7005b0XWq01KxYo 7+caXt9jm/elz21v6e7pSM/Btku/vX9ksw3RZkDL9ooJQ0/WOEk1delag4BZnO19eho+sVmoD ASrPl56/YMsRqV7Z3Q7TGs+dZj+reOX3mQAr40Odtt8AD2cEQd/6zOR32QuVsPfJK66UzgH8m CiH2R/P+Jx6nC83IiCr1IkEmA9iBVmELZTn69wp73lauEuOcy8m0/CIJTGZA/4VKy82XTxmYX rpxQCq1Z0PD1743J Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: > > > > This is not what I meant. You have to use "syscon" as the most generic > > "compatible" value here, but should add a machine specific string > > as a more specific one. "hisilicon,sysctrl" is not appropriate because > > it does not identify the IP block uniquely, you can only use that > > in combination with another more specific string. > > OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value > for the sysctrl node in hi3519.dtsi. > Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl? Is this not called a sysctrl at all in the datasheet then? Arnd