From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011019.outbound.protection.outlook.com [52.101.62.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62FF201113 for ; Fri, 13 Feb 2026 05:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.19 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770960172; cv=fail; b=DOoJZ45eWScMFwQnzvrRaTA1uszswSRX/21jk+wmo5WS14iSZRCYVm+iuCqeUCS1OIoH9wIQfcewlf+0QQZ9cG/zsSgYEqyKPUntZGIZW5ffHaTtBxkyxmqSvg4GszZFuCdKVTBGYLkdx51FB3LA5HVL3oR0ysZ1cAaFRp8bOYE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770960172; c=relaxed/simple; bh=PAjnbek751xTuiw0W4xeEkYkubB/LCy+zCISZKzBTuc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=KzuPti23YOuNt2nR2rVNXjHtm50jsrC4kZUFDlsqK5fge12DKGvsrAkaVMTRuLDd6yuWbechA35sxpsfkRLBnQt9shtZnUFspJklLN2tNpwdj411tomy1hblCX0iLXoTrDvtbwD2K/HYfMretGRB79SwlfFGRBgX+DEdmgVSqW4= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=AZVaZxCm; arc=fail smtp.client-ip=52.101.62.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="AZVaZxCm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vW8oXyDztIVpNV9rHdn47BPCkzIcrHYDLXB1OoKYRGcWYbGHDf/cFnvVAXBDgiJnB8UbQRG6K6Zk+dskRLbaE7KNVz7DOnMsCWnyIzfcYMbpIxtxYYT35FzQnXyTWntJuo6YxkpNsqScZx4ihg3BBsp9yclb7UaZjvlHydSLthjs52RVxweOdAlbVqQZRTT9vnPT/l03tyFZo4CLga2gPCO02bSgqn+2ImfnzdJ6EzlwIqwB2VuK0u+Mi3xy5l2A9kW97AhnEH8DSeDJx5zSW5+3aM2YuiFF5n4+vkmRVBnCqtjcW3kuCwYvVdMlnQipm5hRB5PV+l3MbqopadsegA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sV8oNlCzjye/j+ZOiCi9izvo/z738bMvtY+6tcFJDPs=; b=cL7TFKmIskvvgO1zvOpWK+zOIYF7t+hIisrrwc0vwYoPD2zIEigwcFaP9Hc1EbFcWCyowI5jfLVIxS5y+h0oqV0coIkhL5CE1HwBZKmvseBrECZaFVGacwTk+sqMWMHLtpEtSIaPF+6uR//SesyZKyz6qmwthyl0M07btt1S9ZVXg1JPCJJ3eW2qHtJnnoXtcOfA82BkzJWS44rfXWofWrMZrrtnwNh0NdvrJiuG2m8qmGNB9dDEi5e+bIbZX3ae1vlrGcb1KPTxe6VCEqQMEeNDck/aAyvhSJpearnRNUi9wEK5VJOzGbM6vd4wQQs5o3iUC4V33sSs5S6Rw49ppQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sV8oNlCzjye/j+ZOiCi9izvo/z738bMvtY+6tcFJDPs=; b=AZVaZxCmNhRyRVAfqDIG8UXGb3wJ74Kgz5Ga3sBiq9D5e+M6YF3WcXPbwr/ilak2e9NQkSI69oSwChiBS3SHKx5GhcjLAajzDdRLuqpVMMB6Al0VqygUHiDV3TvLuusrVjU24Bz4rpi8nm37BACBb3zPfzenS75E9O3x8LFDk28= Received: from CH5PR05CA0012.namprd05.prod.outlook.com (2603:10b6:610:1f0::10) by SA3PR12MB7952.namprd12.prod.outlook.com (2603:10b6:806:316::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.13; Fri, 13 Feb 2026 05:22:44 +0000 Received: from CH2PEPF00000140.namprd02.prod.outlook.com (2603:10b6:610:1f0:cafe::19) by CH5PR05CA0012.outlook.office365.com (2603:10b6:610:1f0::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.13 via Frontend Transport; Fri, 13 Feb 2026 05:22:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CH2PEPF00000140.mail.protection.outlook.com (10.167.244.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8 via Frontend Transport; Fri, 13 Feb 2026 05:22:43 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Thu, 12 Feb 2026 23:22:43 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 12 Feb 2026 23:22:42 -0600 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 12 Feb 2026 23:22:39 -0600 Message-ID: <27217771-325a-4545-8a12-80dc6ff5112f@amd.com> Date: Fri, 13 Feb 2026 10:52:38 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] sched: Various reweight_entity() fixes To: Peter Zijlstra , Vincent Guittot CC: Doug Smythies , , , , , , , , , , , References: <002501dc9b16$442a7050$cc7f50f0$@telus.net> <20260211090144.GY1282955@noisy.programming.kicks-ass.net> <20260211104833.GH1395416@noisy.programming.kicks-ass.net> <20260211162825.GZ1282955@noisy.programming.kicks-ass.net> <58c6c115-f544-4c51-990c-a3ad2fbf701a@amd.com> <20260212115943.GB1282955@noisy.programming.kicks-ass.net> <20260212171611.GL1395416@noisy.programming.kicks-ass.net> <20260212193140.GR1395266@noisy.programming.kicks-ass.net> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260212193140.GR1395266@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: None (SATLEXMB04.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000140:EE_|SA3PR12MB7952:EE_ X-MS-Office365-Filtering-Correlation-Id: f7489982-742a-4c46-430c-08de6abfea47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TVo1UzNzc3pPai9zNUx4Q3hJYU1UR2puZUl6VEhOcGhDUEdCYXpQUHBBa0NH?= =?utf-8?B?ZnBoME81VUdIOExQMDRkMXNBc2doeTEzYlFmLzZTcU5rT3Y0NEZDZEtDK2pP?= =?utf-8?B?T1oyL05hKzlxYWk3MS9KSkRHekd4TG45NGZwbmwwS0FkaWcxRktQM0VTYjgr?= =?utf-8?B?aUFrdFZkWVJWVTNUM1phZzZENkFHdFhzTGdKOUs1cHpVeVBya1l0SC96dUFJ?= =?utf-8?B?MkdwRWpQbmorMDRwQ2F2dzJIZUZJaXd5ODJ4S1Z4NXVxYjZsTGFCYmk1MVhr?= =?utf-8?B?SElLcHhuQTdQSXhkWTR0Q0Jtb2JLb1V3WTBOa20ybFRFbjNhYmpFSmFYNXlp?= =?utf-8?B?MDZQTGlySEgxYVdHZ1h3aGNuQzVLNXlUMWZZd0N5VUd5bldaZlpMVGtQRGxF?= =?utf-8?B?QlBFeW5iUEllaTd3elF1OG5KTEJlTzUrZzJ3QTl1RVp3WHdBNHBVWWdjMGEz?= =?utf-8?B?VHp3OXJNRjJSSFBqajZvK1FMdEd4d3ZnbFdHWi9LRTk4TEo3dXR2N1hjTGo5?= =?utf-8?B?Q2ZndE84WnNZRFZaNXErTEwyUlBnRTZLaTcyTm5QdzFPWGZGRmQ4SmFQd3hn?= =?utf-8?B?UmM4dEZ1dkhWYlpYSlNQa0I3UjFoUUkvMmZudjRpK3h1V1hlbjNhdTJQNkZQ?= =?utf-8?B?MVBuQ1RNSkFkdXJ0RHRUYTd3V3hTR0xOR25hWDR2V0pKMitYNVl3a0ZaTFU0?= =?utf-8?B?UGpNcmgxSnJwT1N2cllISTFGRDdJcU1ldTF2dm5uaDdteXlCbnhBQll1RWov?= =?utf-8?B?TElrOFZEUnBEN2EvZU9pSWJsN09MQndpUnZyMWw0bmk1VDNqeUErZVlxR1F5?= =?utf-8?B?SW5zSzR0MGc0c1RQcXV0RXFEZUx5YU80Y05tdzZBZ0FNdDlORmpDUXlLY0Z0?= =?utf-8?B?dE9KRm0rVWxvRXNYWU9vY0RLbTNnQUZtV2ZMdCtpMVg3RjE0WVg5SUFUaXFu?= =?utf-8?B?TDh1K01uc3d3dzVCYnJqbVVmejlBZHF5RDQwWDhDTWRSdUVCQ24xZ2hDTHhS?= =?utf-8?B?SzBTRUVzdDI1dTFmUkhIemhrVnBpNkp5c0k3ZXM5WWdxNEFZQVJJNlJFNEZv?= =?utf-8?B?dDNsaXhkcTVLcEt5aHJ4MnhOYjF1UDJQUkc4ZmhvS3k1ZCs1TzFGbUQwQUxj?= =?utf-8?B?cTRwY2hRVUV1YlkvZmdRdmdzaFlhYWZ1YXd0T1pzbGUxTHMrT1JwQXR4RWt6?= =?utf-8?B?L1p1YXI4cUZmZk8rdFpFN0hQZ2wzT0dvRzUyNUpHQ1psb0ttRWtSOTNYRXVq?= =?utf-8?B?ZEJuUm1WelVlWVdya1YvdEMwdGtBUGJGSHBVaCtjSkJoZkRtM3JHemNPN0px?= =?utf-8?B?a0pXQzkyWGtHVHJVcklpajduSWFxR3MzNm5UakpqYWNZOVZyRE11OFRDdU1E?= =?utf-8?B?OHZVY2l0Z0htU1UwTzBhMS9PS0JiKzlPSW5pOWFlNlU5eTFrckozNEIzaFlp?= =?utf-8?B?TnErblY5Z3QwM0k2TnVvOFVpV082Y1M5RmIwMTNjQTI2R1cxbWJ4OEZFRG40?= =?utf-8?B?cVJVdG1vOGNsU1JyZXpoWEc3dEpvbGhTM2ROVHIreHNRdHhYTWxYZ2pIMHJm?= =?utf-8?B?ZzhEZUZYaUtJWjRtc29acHpqOHdaTGpmRUF0bk1TUk1wNzNGWkV4NU5CNmFu?= =?utf-8?B?SkdQeEkveU1BbWkxMEx6QStXWGUxVEg3Q0F2TUVicWdkbEZhUkx6MjdReGlY?= =?utf-8?B?L21pcm1DemszQ05yYktBUFdCaXVlb20wTHpoUkxOQWxSZWJ0OVJhMDlJWWFO?= =?utf-8?B?bEtBaFNHQm9JUE5YdTdvMUxGTktaVGhHd21UY1JESDhITTdOczh0UXhZUU50?= =?utf-8?B?VEIwUitmaWtMRHNFR1UvYUJCUXdpVGJRLzZpSWZKeklRTUl6MVpYSmVCRTR3?= =?utf-8?B?SjdmQjhqcTdOcG1EVE5KR1h5ajh2ZzY2L09VZ2pYVWlqRUxaYUxOdWF0Q0ov?= =?utf-8?B?cDJWQ1hENnVESGQvSndDOUxpdXowQVZaWUtPNnRRRWFiRHdNemxTTXJHUnhQ?= =?utf-8?B?KzBsWDF5RWhHNlVvUXFVUlRhRStSL1RwSWpVTWNDaTkxd3YwVHVObkVZR0Vl?= =?utf-8?B?b0JWWVhSUVlhZzQvejR0UWNwbDY5TDNQM2JXNStmUytxaGRtUHNsVmQyUzhM?= =?utf-8?B?VWZHTTMwdzJ3UlZBWjVnMXF2azFIZGVNdjN3SWRqSnBEQWd1YmVPSlhEa1ZF?= =?utf-8?B?YXlJbllrbjlyYXpUMkJBM0Uvby95djhSWStqdExkODJCcUVHZWVadXFXYzNk?= =?utf-8?B?aW9wOTY4cEFxVzlCcDZSZnd6UklBPT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: M4gldRHWW19l/S8NzgCfHrXsE30IfjgarTC+YE9ThJcSsktz6Ph5NZbTI6f4Gl8jwmsrb24JtSELTbiiaT8XZDMl4T2qgrzIaPc3YxlfVn7mL4p7A6Nhz+HWHlkBpFwOGEg3CZFtAdzvUO+yM533FPjSi2NXFIV/HF7/w+qSd5XNdX9fqdIIrO2iP3hA40Wz7zkB7Abj6niXGxLbLHnD52AVCPx/ptgVuS1teHPUE/xQdwhc9NZBibSG4dSCn0XgQqXJJt1tT3ejSUouovRuwHa8b10MMyVqKQhy5meNqQAvokZ2I4pbMoKQsEv5NPtGI772aMK6GowyGOgHdikvDdYOO6bZZMEw3wI3wdGpUYQkIOfpWT12cazqlm+9fX3mxWPazr2hn7tKZCG/1SsgRcaUK6ADFEBblMe0ijwkyJUoJ/yLu+AUilJeMZDeZ709 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2026 05:22:43.4727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7489982-742a-4c46-430c-08de6abfea47 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000140.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7952 On 2/13/2026 1:01 AM, Peter Zijlstra wrote: > On Thu, Feb 12, 2026 at 06:24:27PM +0100, Vincent Guittot wrote: > >>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >>> index 5b1a2abb727e..de155be02411 100644 >>> --- a/kernel/sched/fair.c >>> +++ b/kernel/sched/fair.c >>> @@ -797,7 +797,11 @@ u64 avg_vruntime(struct cfs_rq *cfs_rq) >>> if (runtime < 0) >>> runtime -= (weight - 1); >>> >>> +#ifndef CONFIG_64BIT >>> delta = div_s64(runtime, weight); >>> +#else >>> + delta = runtime / weight; >>> +#endif >> >> Good catch >> >> Don't we have the same problem with the div_s64 in place_entity ? > > Indeed so. Let me go fix both and push out a new set. I'll post all the > patches tomorrow once the robot has blessed them. rescale_entity() adds a bunch more of those. Don't those need changing too? (I'm looking at the current sched/core at b4d41dc4bf30). And a wrapper around this pattern would be much appreciated with the amount of ifdeffry that gets added -- Thanks and Regards, Prateek