From: "Liu, Chuansheng" <chuansheng.liu@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
"Zhang, Jun" <jun.zhang@intel.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Liu, Changcheng" <changcheng.liu@intel.com>
Subject: RE: [PATCH v2] sched/fair: fix find_idlest_cpu return -1
Date: Fri, 5 Dec 2014 01:48:25 +0000 [thread overview]
Message-ID: <27240C0AC20F114CBF8149A2696CBE4A01EEA8AF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKfTPtC3cULoGtNz3X+0J0XNe9-aMCrZAocaqiaGKpY+ek1ZSQ@mail.gmail.com>
> -----Original Message-----
> From: Vincent Guittot [mailto:vincent.guittot@linaro.org]
> Sent: Thursday, December 04, 2014 8:15 PM
> To: Zhang, Jun
> Cc: mingo@redhat.com; Peter Zijlstra; gregkh@linuxfoundation.org; Hillf
> Danton; linux-kernel; stable@vger.kernel.org; Liu, Chuansheng; Liu,
> Changcheng
> Subject: Re: [PATCH v2] sched/fair: fix find_idlest_cpu return -1
>
> On 4 December 2014 at 12:43, <jun.zhang@intel.com> wrote:
> > From: zhang jun <jun.zhang@intel.com>
> >
> > in function select_task_rq_fair, when find_idlest_cpu return -1 and sd->child
> == NULL
> > select_task_rq_fair return -1, system panic.
>
> you forgot to add on which kernel version this patch applies.
>
> We don't have such issue on 3.18-rc7 as find_idlest_cpu don't return
> -1. We only need a cleanup of the test against -1 for 3.18-rc
>
Agreed, so Jun can make two patches:
The first one patch is in find_idlest_cpu() to not return -1 and based on stable-branch such as 3.14.x;
The second patch is one cleanup for new_cpu == -1 judgment against the 3.18-rc, since it is no possibility now;
Best Regards
Chuansheng
prev parent reply other threads:[~2014-12-05 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 11:43 jun.zhang
2014-12-04 12:15 ` Vincent Guittot
2014-12-05 1:48 ` Liu, Chuansheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27240C0AC20F114CBF8149A2696CBE4A01EEA8AF@SHSMSX101.ccr.corp.intel.com \
--to=chuansheng.liu@intel.com \
--cc=changcheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=jun.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®