RE: [PATCH] printk: fixing the deadlock when calling printk in nmi handle

["Liu, Chuansheng" <chuansheng.liu@intel.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1181 bytes --]

> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: Wednesday, July 04, 2012 10:52 PM
> To: Liu, Chuansheng
> Cc: 'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org); kay@vrfy.org;
> gregkh@linuxfoundation.org; mingo@elte.hu
> Subject: RE: [PATCH] printk: fixing the deadlock when calling printk in nmi
> handle
> 
> On Wed, 2012-07-04 at 16:50 +0200, Peter Zijlstra wrote:
> > On Wed, 2012-07-04 at 14:46 +0000, Liu, Chuansheng wrote:
> > > > > I took many time to dig out this issue.
> > > >
> > > > Well, it was a known issue..
> > > Still feel unfair :)
> > > If this is a known issue that calling printk is not safe in nmi
> > > handler, Why not defense it like this patch before real solution coming out?
> >
> > Why replace one broken thing with another broken thing?
> 
> Also, I much prefer obviously broken over subtly broken.
Supporting your opinion totally, but from production view, it is not a good thing that system crash,
I prefer to lose one log instead:)
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥