mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Liu, Chuansheng" <chuansheng.liu@intel.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] firmware loader: Fix the concurrent request_firmware() race for kref_get/put
Date: Fri, 9 Nov 2012 08:21:27 +0000	[thread overview]
Message-ID: <27240C0AC20F114CBF8149A2696CBE4A1C1F20@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CACVXFVN7RVzQB5X8h=XazQm+vwwwKzGyAm5jNhiYbdqTJeR_TQ@mail.gmail.com>

> $./scripts/checkpatch.pl
> ERROR: space required before the open parenthesis '('
> #97: FILE: drivers/base/firmware_class.c:267:
> +	if(!kref_put(&buf->ref, __fw_free_buf))
> 
> 
> > +               spin_unlock(&fwc->lock);
> >  }
> >
> >  /* direct firmware loading support */
> 
> After fixing the patch style error, you can add my ack:
> 
Thanks your pointing out, fix it soon.

  reply	other threads:[~2012-11-09  8:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 12:28 Chuansheng Liu
2012-11-09  8:16 ` Ming Lei
2012-11-09  8:21   ` Liu, Chuansheng [this message]
2012-11-09 17:27 ` [PATCH V2] " Chuansheng Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27240C0AC20F114CBF8149A2696CBE4A1C1F20@SHSMSX101.ccr.corp.intel.com \
    --to=chuansheng.liu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®