From: Bitan Biswas <bbiswas@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
<linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Peter Rosin <peda@axentia.se>,
Wolfram Sang <wsa@the-dreams.de>
Cc: Shardar Mohammed <smohammed@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Mantravadi Karthik <mkarthik@nvidia.com>
Subject: Re: [PATCH V9] i2c: tegra: remove BUG() macro
Date: Tue, 18 Jun 2019 04:52:39 -0700 [thread overview]
Message-ID: <2724f809-fe0b-810c-6236-d94a1efc2112@nvidia.com> (raw)
In-Reply-To: <e1bf5aac-5528-3e54-0f41-5a1bbabce419@gmail.com>
On 6/18/19 4:29 AM, Dmitry Osipenko wrote:
> 18.06.2019 14:09, Bitan Biswas пишет:
>> The usage of BUG() macro is generally discouraged in kernel, unless
>> it's a problem that results in a physical damage or loss of data.
>> This patch removes unnecessary BUG() macros and replaces the rest
>> with warning.
>>
>> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
>> ---
>> drivers/i2c/busses/i2c-tegra.c | 47 +++++++++++++++++++++++++++++++++++-------
>> 1 file changed, 39 insertions(+), 8 deletions(-)
>
> Thank you very much! Please keep applying all the advises that were given to you
> during the reviews in the future patches.
Thank you Dmitry for the review inputs and patience. I shall try to keep
the advices in mind for future reviews.
>
> I made a quick test and no problems spotted, all warning spots are silent.
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
>
Also, Thank you for help in testing the patch at your end.
-regards,
Bitan
next prev parent reply other threads:[~2019-06-18 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 11:09 Bitan Biswas
2019-06-18 11:29 ` Dmitry Osipenko
2019-06-18 11:52 ` Bitan Biswas [this message]
2019-06-20 5:00 ` Bitan Biswas
2019-06-20 9:23 ` Laxman Dewangan
2019-06-20 10:30 ` Thierry Reding
2019-06-21 21:26 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2724f809-fe0b-810c-6236-d94a1efc2112@nvidia.com \
--to=bbiswas@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkarthik@nvidia.com \
--cc=peda@axentia.se \
--cc=skomatineni@nvidia.com \
--cc=smohammed@nvidia.com \
--cc=treding@nvidia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®