From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42C263A4508 for ; Wed, 20 May 2026 10:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779273097; cv=none; b=FcmcYxXd/sLeSjJacIqvxMtQ+D3IkJczOFq/3dANX33555oA0Y46aK29/EqAsuT1On+sdYW+blxm9NZuobYxsnosLcwkTyr8yjMsrq4X/WfDOBThH3JMOjnjdZppWVNRgvwV84EHl2JhkQu2jV9tawDOvVaGNUY17Wgd1aDZQcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779273097; c=relaxed/simple; bh=qakm++Qxfsw3BftXjDriuyLuPdXol7P4QCWanM3YoHc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EPpPR6qW78tAR8PnTG8MpUCtxW22qpuAjX6gQ0av7jUHz8++eisFNslI41hZ4dmTdo8rzIY6PrKmtEs4qZ6J2AjG8F9fSqaGeLvsxEZqjJl1/l7lvqrcekfiDQutsNWvFjDsT3ipRq5GGgPOOqwVZ8oZPWST3jRNfUlyAecjgIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pjQ/qj4g; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cOuPBDlz; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pjQ/qj4g"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cOuPBDlz" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64K8uaRm4115174 for ; Wed, 20 May 2026 10:31:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C4Dq226a3Dt2Z7umro/qS9Vqjk6BVNhNKCyQse8jmis=; b=pjQ/qj4gKU2E8o6X 2qibpa84lOGA1z/Z+dFFT7B7z/zrylF3U7AmDFiFF3t46uxm9TbkprrRUC+SbCbF SLakd236sXraqXSj7DMABofbAK3hj3ey91a6s+SO486Zs5EXMgjd9nVmGSknqASY /GZgP92KyQzxZZviCoRsSzPyJo4hJDh5CJfymcrjAzuc1zZ9YrBjXxHuqeoxlYKN b9qg3n54qaATP9GQGtl+gnwknKW95d1lofsdJtdwoSMv8+FDgQ0NCJYXTd4hBrWZ AyTSLiApFrbpUdtp+v7lNKEx6jw/0lRLAedd4rV0E1KoCx/5ZXspveCpB2Tq/4JJ wyOa6g== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e99w0gc2n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 10:31:31 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c82ba4715b6so4954697a12.2 for ; Wed, 20 May 2026 03:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779273091; x=1779877891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C4Dq226a3Dt2Z7umro/qS9Vqjk6BVNhNKCyQse8jmis=; b=cOuPBDlz8QrAmvS4NyXjocGXzLpaftY/SN/+/ROatNrnI8tuyiSszwycycEVbmnH66 BKwp67rc6e/1e469sDx0v92GZiq2sihNlQRf38aD9VQn+R4h1yBOyeZVx+Qwh8+pCvsY XrYElxsAGv5oKWKtmKh5HYcXiRCfHxGnI74DYysT0FTPCgy+FAMwiODj8yiA8x5hYQ8V BDnrvRPc0YN1dy5y9YMgcTRaFamtGJX2U2vVgiY/B3FWHvES8127WSfKC2jHJ7p+ZFMF NJNH2HlI3bqac4V0kimwxEEtZyjNfwdrB53dyV7XajFvDMyxTdT7Zxv1fU3NEFO7SoVC spOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779273091; x=1779877891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C4Dq226a3Dt2Z7umro/qS9Vqjk6BVNhNKCyQse8jmis=; b=oHifFVLOBABZ6ZekBIbgjob1ejw4nf940VdK6Hm09Wr4uHLn3wMYa/5Wr3gHrcxI7t AnjjVyrcu4CABRNgwGt42w8dGr8QEHu2RJvzGHBQQoGm2uChfMQenqzkAFM9v2N5QWao G6H8YBxCtkvKvtKTIqI9UxhXOukk1RipQ0jisbmg5f7lS5qfidl/lMHGmof1usQ8y9QW +m5OYpZr3GqushYurc/J2/hF3wehnZtg9F+9lnS4oIPWYkvXsuQbZVnqRHjgByW9Axzv CCW5ZrqtnHBPHh8ggLaNFmlKGs0MwZ3QxeRwtm8l88n7x7AbduLcqQawEaNbAf7jJrM2 VW5Q== X-Forwarded-Encrypted: i=1; AFNElJ9KZdBx7wBSPoR8Ez4TBtjubmII2Yzc5HRaWFuhu2INwf/jhH2vHj7i1FXinWbuMPO4JwS/pcaFNdxoyDw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9sUrzGxA7zj3sVsJqgSJtrTyHDyCSx0s3ZHbqdVbUfOF+Cf0g LkcSy8Ymqj+Sl99k68zNIjAB3ExXJKXleIGWxNEOXQ7dntIme1mgy9yC/NAOKTY/qXt+1SiuFTn +qx/+KAx1r6ISEVHKM/oObcgHoaEaI/Qe8XybqBBWJNVTcvkJFDMXbPhokGNiUIoGriY= X-Gm-Gg: Acq92OGNRswZdPaoAEfrPWaX2Ta3440S9vHcc+kSUXPd0E34W3nAtl4i1IcJQUJTm7P UB6IciM9/qYYU/0O4uceCVnJFHJFntXUzoGUAy89MUTsq/Z5uXBtDDjbYtbPqUcGmhQ6OY2PmCw dWZqq8WoYcWJyUcDMzw9/p0hiYl37Kzf4uPwfNzwz3wHDOtC42KoBGyuFDxELNgyURqmop6ByX1 h/HPOsC8mkOzx7nB62LKL5krgAE3e1SKRFTs3ePVHKSG42XYmf0pxAlJncpXa1LNvW7CZdzKmHT oivcuWCgEFtF4rhbKpAZWSnFZBFoGyQ10frIQu4HTZiSGtbxERWgcWpQymKrXFH052UmHcwOLc7 aqpV+wlolOEuqXNj2vksFGi+RxrcXM5ufczTs7yKzxbej3qvdbcGcPdl7NlsXxJ1bXUlO6Obs18 YaMjY9a78xSipaYH7Ze2t9rvtWoblM X-Received: by 2002:a05:6a00:2449:b0:82f:9de6:3b2a with SMTP id d2e1a72fcca58-83f33c4ea4dmr24974542b3a.8.1779273090659; Wed, 20 May 2026 03:31:30 -0700 (PDT) X-Received: by 2002:a05:6a00:2449:b0:82f:9de6:3b2a with SMTP id d2e1a72fcca58-83f33c4ea4dmr24974511b3a.8.1779273090151; Wed, 20 May 2026 03:31:30 -0700 (PDT) Received: from [10.133.33.114] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f196660f9sm26137010b3a.10.2026.05.20.03.31.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 03:31:29 -0700 (PDT) Message-ID: <272690cf-ca46-4b21-a979-3c89de15747c@oss.qualcomm.com> Date: Wed, 20 May 2026 18:31:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/39] drm/msm/dp: allow dp_ctrl stream APIs to use any panel passed to it To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> <20260410-msm-dp-mst-v4-8-b20518dea8de@oss.qualcomm.com> <09c14a80-d981-4584-b4bb-8fb2430d7a0a@oss.qualcomm.com> <6b6uc5lk4tsxccwyyqlp4u6sqsv3x3uyu32qmgl63rgb2m4wuz@wjcroowka3zq> Content-Language: en-US From: Yongxing Mou In-Reply-To: <6b6uc5lk4tsxccwyyqlp4u6sqsv3x3uyu32qmgl63rgb2m4wuz@wjcroowka3zq> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 0wYn5s8cJG1ZZoFiGqmpPZB-CTFUudhS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDEwMSBTYWx0ZWRfXwHgJCAkvNIBl uIy5RqqdVGddwxUb/62jAWXFMnkobm04sZOBbPA8JZw2536rwa88oManQSOtVeqM2nmzRvrvboy cXXMypKImRKP+XK5VTZx7WK1X5wt+8r6+HuI3Mg8BkzZjQs8dWFtNY00K33YFLI4LftFBX0vrbO Vbh00Br4LWndm/CQ7WdZhzrPxZcvpbbw9KssWw3jf6rCwqIm9hctkIgN5VJJpnvyQFxeC5wxdPH UKV+z9wbqCXK0t3G2YmlPj2US98TNLzUQtvp2KVLnAN4o2aaZ0U0+v4briw/tym8uiHqJEDwZYt tl3e3eaMzJAf+Uq8XwGsscBSiLmpz+DckMNV6AB7Gfw5jRLky0ZseVfHAoQmGAI4hJ5YRnB4Y7j wmtw+2rsW7OikDX4y6+5OhygeHsZ6bXTO8YUZedmvQ/6n9wP4/YUioxYPif8kaj9t86QGU9FGeC XblffoGwfZUnfrbKGxg== X-Authority-Analysis: v=2.4 cv=RZigzVtv c=1 sm=1 tr=0 ts=6a0d8d83 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=GPxS-sztI-lhh4Ud1vIA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 0wYn5s8cJG1ZZoFiGqmpPZB-CTFUudhS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200101 On 5/20/2026 5:24 PM, Dmitry Baryshkov wrote: > On Tue, May 19, 2026 at 03:52:35PM +0800, Yongxing Mou wrote: >> >> >> On 4/12/2026 1:38 AM, Dmitry Baryshkov wrote: >>> On Fri, Apr 10, 2026 at 05:33:43PM +0800, Yongxing Mou wrote: >>>> From: Abhinav Kumar >>>> >>>> Currently, the dp_ctrl stream APIs operate on their own dp_panel >>>> which is stored inside the dp_ctrl's private struct. However with MST, >>>> the stored panel represents the fixed link and not the sinks which >>>> are hotplugged. Allow the stream related APIs to work on the panel >>>> which is passed to them rather than the stored one. For SST cases, >>>> this shall continue to use the stored dp_panel. >>> >>> Hmm. Why? Can't we get rid of it (in the followup patch)? >>> >> In MST, the stream panel is bound to the connector, but in SST the panel is >> still stored in msm_dp_display_private and msm_dp_ctrl_private, so >> dropping it does not seem necessary at this point. The purpose of these >> changes is to allow the functions to operate on the MST panel data passed in >> per stream. > > I understand the panel being stored in msm_dp_display_private. Can we > drop it from msm_dp_ctrl_private? > Dropping panel from msm_dp_ctrl_private would require adding a panel parameter to approximately 15 functions in dp_ctrl.c. Would you like us to do that in this patch? >>>> >>>> Signed-off-by: Abhinav Kumar >>>> Signed-off-by: Yongxing Mou >>>> --- >>>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 21 +++++++++++---------- >>>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 2 +- >>>> drivers/gpu/drm/msm/dp/dp_display.c | 2 +- >>>> 3 files changed, 13 insertions(+), 12 deletions(-) >>>> >