From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbdKTWUZ convert rfc822-to-8bit (ORCPT ); Mon, 20 Nov 2017 17:20:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53110 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdKTWUX (ORCPT ); Mon, 20 Nov 2017 17:20:23 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20171120135820.32596-1-colin.king@canonical.com> References: <20171120135820.32596-1-colin.king@canonical.com> To: Colin King Cc: dhowells@redhat.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] afs: remove redundant assignment of dvnode to itself MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27269.1511216421.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 20 Nov 2017 22:20:21 +0000 Message-ID: <27271.1511216421@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 20 Nov 2017 22:20:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The assignment of dvnode to itself is redundant and can be removed. > Cleans up warning detected by cppcheck: > > fs/afs/dir.c:975: (warning) Redundant assignment of 'dvnode' to itself. > > Fixes: d2ddc776a458 ("afs: Overhaul volume and server record caching and fileserver rotation") > Signed-off-by: Colin Ian King Applied, thanks. David