mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: lyude@redhat.com
To: Francesco Magazzu <postadelmaga@gmail.com>,
	Danilo Krummrich <dakr@kernel.org>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	 linux-kernel@vger.kernel.org, Karol Herbst <kherbst@redhat.com>
Subject: Re: [PATCH 0/2] drm/nouveau/clk: fix RAM error handling and pstate desync in nvkm_pstate_prog
Date: Thu, 17 Sep 2026 16:51:18 -0400	[thread overview]
Message-ID: <27293a63217c3261c42d011cef8cf31e3d43fefd.camel@redhat.com> (raw)
In-Reply-To: <20260727152821.128432-1-postadelmaga@gmail.com>

For the whole series:

Reviewed-by: Lyude Paul <lyude@redhat.com>

Will push to drm-misc-fixes in just a moment

On Mon, 2026-07-27 at 17:28 +0200, Francesco Magazzu wrote:
> Follow-up to "[PATCH v2 0/4] drm/nouveau: fix list cursor use after
> loop
> in the clk pstate paths"
> (20260712123616.1180830-1-postadelmaga@gmail.com).
> Sashiko AI review flagged three pre-existing issues while reviewing
> patch
> 2/4 of that series; the third (clk->func->prog()'s error being
> clobbered
> by nvkm_volt_set_id() in nvkm_cstate_prog()) is already fixed by
> patch 4/4
> of that series. These two patches address the other two:
> 
>   1. nvkm_pstate_prog() drops the RAM reclock error and falls through
> to
>      core clock programming anyway.
>   2. nvkm_pstate_prog() commits clk->pstate to the new state before
> the
>      hardware transition has actually succeeded.
> 
> Francesco Magazzu (2):
>   drm/nouveau/clk: don't ignore RAM clock programming errors in
>     nvkm_pstate_prog
>   drm/nouveau/clk: only update clk->pstate after hardware programming
>     succeeds
> 
>  nvkm/subdev/clk/base.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)


  parent reply	other threads:[~2026-09-17 20:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 15:28 Francesco Magazzu
2026-07-27 15:28 ` [PATCH 1/2] drm/nouveau/clk: don't ignore RAM clock programming errors " Francesco Magazzu
2026-07-27 15:28 ` [PATCH 2/2] drm/nouveau/clk: only update clk->pstate after hardware programming succeeds Francesco Magazzu
2026-08-01 12:11 ` [PATCH 0/2] drm/nouveau/clk: fix RAM error handling and pstate desync in nvkm_pstate_prog Francesco Magazzu
2026-09-17 20:51 ` lyude [this message]
2026-09-17 21:14   ` lyude

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27293a63217c3261c42d011cef8cf31e3d43fefd.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kherbst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=postadelmaga@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®