From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED85308F3A for ; Fri, 12 Dec 2025 20:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765570258; cv=none; b=GEWEILpDR7uyF1RtoUMpiip4fgTVzf9wSKXFqZXMstgSh5GmRNdt72oLkl044y6FGi6ZCOaaQtmDtvPyDoADD9aj1W8/sjIJWnX9QTYovMI6ZJatjGkOcziHJn0KAZbx2wltdBDZYQD55r7/cw/ZOZhosnl9//rud+D14vFKXac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765570258; c=relaxed/simple; bh=4gfCtO9+aoCvqYEay1XZJUUI1s50LzgL381O6T7z7FE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RfW6hGVCImRjQE1D7f/HTaIhGJuvhVocIdSjnq5/mP6zMtf4erXfjIE+yNea6noOjotOPINvebTzjqD2fjZRLyajMnROOq53rmt0WKLoTiVqxkgm/J1R4CoGcnztHdDqgL3SRWPb/Gv1+5HckGiY7GTSfQALJOpn6Amih+UwLiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=kMcM4LWP; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="kMcM4LWP" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-29efd139227so18234125ad.1 for ; Fri, 12 Dec 2025 12:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1765570255; x=1766175055; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gsVed5WgXtZPXSfJ2PXjLRbNCmFwRAyF31OH8siBSJw=; b=kMcM4LWPOOW5aofuFjI2DOpQEcNRY9pNxIjsXTaODIbDPKMC5FNcR7RvUO9eXo7mUq 6BsGnJ80Xlb32jsfGAp+kCt1gImNMKb/QKdXHMJzk3bvdv8jJhbJphheaDpf4gyuL5OG HydGJQiIETyM9h3gNatOuE/XUa43fmZn6KP8wz9r5te3Ta0LYeDWaXyvX2hZGRTaXuXg /iNRw/JmobBVs/4eJJRU3EsIFK6gjThqYZOWcBvyjw/thYYPRJAIm93s1R1dBxjNosQg yLY2UQskQxlKMiLFwHf+C19An1ecALJSPCTKVzeWTZrQ5wRsmfgnj+Hjun9X4HRLWPjc cWWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765570255; x=1766175055; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gsVed5WgXtZPXSfJ2PXjLRbNCmFwRAyF31OH8siBSJw=; b=OZuRX80ZcbIK2hWO12frKk5Jgg/yk9uTPetmoxT591+Afl7fKcCd76hT+AO0W+9eHW u9LNKeyfaW3kemQNLoJSoS4SkuQHDscVOMZJtvvAYQZvebseET4c1BNf0dCJ9OdTVgYk S4AqtY+H/uyrzs0HgoqYOSSJPEcmCik1w9GehWvhrSmacFmeMNrf34uUzxfV0HvuHrTB dMuwiHfINqLNqIIoljXFb/GICukwKNJCbcVgvjItCxwnHAfnlIDESAi25a9YRT0gJZb2 ljH6cwpErJWfu/lp3qugMMXhAxAXcUR0kiPPqeAfdZ4hGQNB3E+0TCjyMJo+3xoefKGd TB9w== X-Forwarded-Encrypted: i=1; AJvYcCV5IesIB+QlFUvyJHyGfwO0/hvn0H4NnzViqN3y6GUX6cuUjYWAUQfX8vyXQyCL6zCYSCJOFIkIZCf42lA=@vger.kernel.org X-Gm-Message-State: AOJu0YwM+2K5uePv5nV1DmPfFkyWgMLUpNDBbOxn3lMLE1+zArl8cNqr 0tP+1kmfB54kG+3igXxIdw3TVOBT0PASqgW210oCMzJ3B2vHwH+5VHiUNLPJmaRoOkA= X-Gm-Gg: AY/fxX4ng5CVvATgclBlk1bs/yA37ez+hrpiEBn824Xwb4tlWXf0ilsgaAqHx7hwcWl y3nYVWd+uH9JFmbggO0BDm0B9bxfgU/YcCZg64JG4PGrRGHaxG1RwkHnz97UfBBXxGAfV3z1v7D KFMo7TQLMODshpeSiWn4D42lWO/IJgGh9yLjYfzyoqYiWSPsm9q2Zf+Dun+zAe1xnZ9WmM1HC/j Tlsiol7SJ209FRNwVsvu2TRDKPrlZfeHBPjivqm7xgWm0RZRG8wKcBFe8t/y+ynBxP5jZzMMGit FPFCPc4WK7esHmn9hmD56nwfMn4GYO5NhNnSCk/7n198wB5YeLlNwPsn6vP/FFEngplOZOu4za4 PUdYAwOkGPr51O84p8tfRQ3TWsYL7HI5imNClDGWXgtywMHSR8YEZpKh5MYsFDKqpImYvkgXY7q f/6KfkCdkMQSrMm0ks9yW/WDy2ngemqz2N9leZyO5DUn/cox9mXw== X-Google-Smtp-Source: AGHT+IH4YKlBbDeLqTy95z05gm75S6dqOblA2F2FrB859WtV1ZEekn7/gpBPyoL8TMFo+3JpfAzaQQ== X-Received: by 2002:a17:902:f688:b0:29f:29a8:608b with SMTP id d9443c01a7336-29f29a861cemr19807075ad.13.1765570255065; Fri, 12 Dec 2025 12:10:55 -0800 (PST) Received: from [172.20.4.188] (221x255x142x61.ap221.ftth.ucom.ne.jp. [221.255.142.61]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29ee9d38c7fsm62825655ad.39.2025.12.12.12.10.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Dec 2025 12:10:54 -0800 (PST) Message-ID: <2729b31b-ba58-4f32-b71a-75bd07524ac8@kernel.dk> Date: Fri, 12 Dec 2025 13:10:50 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 03/11] block: move around bio flagging helpers To: Pavel Begunkov , Christoph Hellwig Cc: linux-block@vger.kernel.org, io-uring@vger.kernel.org, tushar.gohad@intel.com, Keith Busch , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org References: <6cb3193d3249ab5ca54e8aecbfc24086db09b753.1763725387.git.asml.silence@gmail.com> <4ed581b6-af0f-49e6-8782-63f85e02503c@gmail.com> From: Jens Axboe Content-Language: en-US In-Reply-To: <4ed581b6-af0f-49e6-8782-63f85e02503c@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/11/25 6:08 PM, Pavel Begunkov wrote: > On 12/4/25 10:43, Christoph Hellwig wrote: >> On Sun, Nov 23, 2025 at 10:51:23PM +0000, Pavel Begunkov wrote: >>> We'll need bio_flagged() earlier in bio.h in the next patch, move it >>> together with all related helpers, and mark the bio_flagged()'s bio >>> argument as const. >>> >>> Signed-off-by: Pavel Begunkov >> >> Looks good: >> >> Reviewed-by: Christoph Hellwig >> >> Maybe ask Jens to queue it up ASAP to get it out of the way? > > I was away, so a bit late for that. I definitely wouldn't > mind if Jens pulls it in, but for a separate patch I'd need > to justify it, and I don't think it brings anything > meaningful in itself. I like getting prep stuff like that out of the way, and honestly the patch makes sense on its own anyway as it's always nicer to have related code closer together. -- Jens Axboe